Skip to content

Commit 71ac8a3

Browse files
committed
[GEN-1863] TODO comments for DataGrid pagination implementation on pending areas
Add TODO comments to remind converting DataGrid components to use paginated ReadData instead of loading all records in memory for better performance on Apis, Keys, and Nodes pages. These are low-usage views and we can do it on the future. stack-info: PR: #485, branch: Jossec101/stack/18
1 parent 6b31d14 commit 71ac8a3

6 files changed

Lines changed: 5 additions & 15 deletions

File tree

src/Pages/Apis.razor

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
<Row>
1212
<Column ColumnSize="ColumnSize.Is12">
13+
@* TODO: Convert this grid to paginated ReadData to avoid loading all records in memory. *@
1314
<DataGrid TItem="APIToken"
1415
Data="@_apiTokens"
1516
Editable="true"

src/Pages/Index.razor

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/Pages/Index.razor.css

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/Pages/Keys.razor

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
<Row>
1212
<Column ColumnSize="ColumnSize.Is12">
13+
@* TODO: Convert this grid to paginated ReadData to avoid loading all records in memory. *@
1314
<DataGrid TItem="Key"
1415
Data="@userKeys"
1516
Editable="true"

src/Pages/Nodes.razor

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
<Row>
1414
<Column ColumnSize="ColumnSize.Is12">
15+
@* TODO: Convert this grid to paginated ReadData to avoid loading all records in memory. *@
1516
<DataGrid TItem="Node"
1617
Data="@_nodes"
1718
Editable="@_editable"
@@ -194,6 +195,7 @@
194195
<CloseButton />
195196
</ModalHeader>
196197
<ModalBody>
198+
@* TODO: Convert this grid to paginated ReadData to avoid loading all records in memory. *@
197199
<DataGrid TItem="ApplicationUser"
198200
Data=@_selectedNode?.Users
199201
Sortable="false"

src/Pages/Wallets.razor

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
@page "/"
12
@page "/wallets"
23
@using System.Security.Claims
34
@using System.Linq;

0 commit comments

Comments
 (0)