Global game state breaks multiplayer

[EliotGodard]

Problem

agxgame.js stores questions as a single module-level array. If two hosts create games simultaneously, they overwrite each other's question set.

Suggested fix

Store game state in a Map keyed by gameId so each room has its own isolated state (questions, round counter, ploys, etc.).

[EliotGodard]

@claude any thought ?

[claude]

Claude finished @EliotGodard's task in 2m 49s —— View job • claude/issue-2-20260130-1625 • Create PR ➔

---

Analysis & Implementation

• Read repository guidelines (CLAUDE.md)
• Examine agxgame.js to understand current implementation
• Analyze the global state issue
• Implement the fix
• Commit and push changes

My Analysis

You're absolutely right about this issue! I've examined agxgame.js and confirmed the problem:

Current Issue (agxgame.js:9):

var questions = [];

This single module-level array is shared across ALL games. When hostPrepareGame() is called (line 73), it overwrites the global questions array:

questions = JSON.parse(body);  // Line 73 - overwrites for ALL games!

Impact:

• If Host A creates a game with English questions and Host B creates a game with French questions simultaneously, both games will end up using whichever questions were loaded last
• The sendQuestion() function (line 229) reads from this global array, so all games share the same question set
• Round counters and other state are passed via socket events, but the questions themselves are globally shared

Implementation

I've implemented the fix using a Map keyed by gameId. Here's what changed:

1. Replaced global state (agxgame.js:9-10):

// Store game state per gameId to support multiple simultaneous games
var gameStates = new Map();

2. Initialize game state when creating a game (agxgame.js:51-55):

gameStates.set(thisGameId, {
    questions: [],
    round: 0
});

3. Store questions per game (agxgame.js:82-89):

const gameState = gameStates.get(data.gameId);
if (gameState) {
    gameState.questions = JSON.parse(body);
    console.log("Questions for game", data.gameId, ":", gameState.questions);
}

4. Read from game-specific state (agxgame.js:237, 109-119):

• sendQuestion() now retrieves questions from gameStates.get(gameId).questions
• hostNextRound() checks game-specific question count

5. Clean up state when game ends (agxgame.js:119-121):

gameStates.delete(data.gameId);
console.log("Game", data.gameId, "ended. State cleaned up.");

This ensures each game room maintains isolated state and prevents interference between simultaneous games.

---