Skip to content

Improve validation of ACCESS_CONTROL_TYPE settings for the FederatedMetastore #167

@patduin

Description

@patduin

From the docs:

Primary metastores can configure access-control-type to have any of the described access-control-types whereas federated metastores may only be configured to READ_ONLY and READ_AND_WRITE_ON_DATABASE_WHITELIST.

The validation for these settings should be done on the configuration object com.hotels.bdp.waggledance.api.model.FederatedMetaStore. Instead currently the settings are validated in the com.hotels.bdp.waggledance.server.security.AccessControlHandlerFactory which isn't launched until a request made. Ideally WD shouldn't start if the configuration is wrong.

Acceptance Criteria:

  • WD doesn't start when the FederatedMetastore is configured with access_control_values: READ_AND_WRITE_AND_CREATE or READ_AND_WRITE_AND_CREATE_ON_DATABASE_WHITELIST.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions