From cd23e3f272bbe5c860dc1cca4aa2c8d2ca5d65d2 Mon Sep 17 00:00:00 2001 From: winrid Date: Tue, 30 Jun 2026 13:41:44 -0700 Subject: [PATCH 1/3] Require fastcomments-php ^3.0 Pin to the 3.0.0 SDK line instead of the wildcard `*`, and update composer.lock (fastcomments-php v1.2.0 -> v3.0.0). No code changes. --- composer.json | 2 +- composer.lock | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/composer.json b/composer.json index 3cbb693..6640a61 100644 --- a/composer.json +++ b/composer.json @@ -22,7 +22,7 @@ "illuminate/support": "^10.0|^11.0|^12.0", "illuminate/view": "^10.0|^11.0|^12.0", "illuminate/contracts": "^10.0|^11.0|^12.0", - "fastcomments/fastcomments-php": "*", + "fastcomments/fastcomments-php": "^3.0", "fastcomments/sso": "*" }, "require-dev": { diff --git a/composer.lock b/composer.lock index 04bde00..ef81c30 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "This file is @generated automatically" ], - "content-hash": "6cfca803ad0452ccf0bd61ed662efec8", + "content-hash": "5f9d67b3d37b41aa506c8f065712514e", "packages": [ { "name": "brick/math", @@ -510,16 +510,16 @@ }, { "name": "fastcomments/fastcomments-php", - "version": "v1.2.0", + "version": "v3.0.0", "source": { "type": "git", "url": "https://github.com/FastComments/fastcomments-php.git", - "reference": "e2e78615a79227417358bf9696a35f4ba016efa0" + "reference": "236b5df721fa1bdd1cd8e19b945f33a4549c79fc" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/FastComments/fastcomments-php/zipball/e2e78615a79227417358bf9696a35f4ba016efa0", - "reference": "e2e78615a79227417358bf9696a35f4ba016efa0", + "url": "https://api.github.com/repos/FastComments/fastcomments-php/zipball/236b5df721fa1bdd1cd8e19b945f33a4549c79fc", + "reference": "236b5df721fa1bdd1cd8e19b945f33a4549c79fc", "shasum": "" }, "require": { @@ -528,7 +528,7 @@ "ext-mbstring": "*", "guzzlehttp/guzzle": "^7.3", "guzzlehttp/psr7": "^1.7 || ^2.0", - "php": "^7.4 || ^8.0" + "php": "^8.1" }, "require-dev": { "friendsofphp/php-cs-fixer": "^3.5", @@ -567,9 +567,9 @@ ], "support": { "issues": "https://github.com/FastComments/fastcomments-php/issues", - "source": "https://github.com/FastComments/fastcomments-php/tree/v1.2.0" + "source": "https://github.com/FastComments/fastcomments-php/tree/v3.0.0" }, - "time": "2026-01-09T04:18:56+00:00" + "time": "2026-06-30T19:19:04+00:00" }, { "name": "fastcomments/sso", From 39bd0ec75143f40d4317819c24a7c28c76732d9e Mon Sep 17 00:00:00 2001 From: winrid Date: Tue, 30 Jun 2026 14:40:15 -0700 Subject: [PATCH 2/3] CI: pin orchestra/testbench to each Laravel major The Laravel 10/11 matrix jobs could no longer resolve: with no testbench constraint, composer picks testbench 10 (which now requires Laravel 12) and can't fall back to a non-advisory Laravel 10/11. Pin testbench 8/9/10 to Laravel 10/11/12 so each job resolves the matching framework. Pre-existing drift, surfaced on this PR. --- .github/workflows/tests.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index eb32398..9407d15 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -24,6 +24,16 @@ jobs: # Laravel 12 requires PHP 8.2+ - php: '8.2' laravel: '12' + include: + # Pin orchestra/testbench to the major matching each Laravel version + # (8 -> Laravel 10, 9 -> 11, 10 -> 12) so resolution doesn't pull + # testbench 10 (which requires Laravel 12) onto the 10/11 jobs. + - laravel: '10' + testbench: '8' + - laravel: '11' + testbench: '9' + - laravel: '12' + testbench: '10' name: PHP ${{ matrix.php }} – Laravel ${{ matrix.laravel }} @@ -40,7 +50,7 @@ jobs: - name: Install dependencies run: | - composer update --with "illuminate/support:^${{ matrix.laravel }}.0" --with "illuminate/view:^${{ matrix.laravel }}.0" --with "illuminate/contracts:^${{ matrix.laravel }}.0" --no-interaction --prefer-dist + composer update --with "illuminate/support:^${{ matrix.laravel }}.0" --with "illuminate/view:^${{ matrix.laravel }}.0" --with "illuminate/contracts:^${{ matrix.laravel }}.0" --with "orchestra/testbench:^${{ matrix.testbench }}.0" --no-interaction --prefer-dist - name: Run tests run: vendor/bin/phpunit From 25fcad33fe3ec01d62766deb1ead8297168ba2e4 Mon Sep 17 00:00:00 2001 From: winrid Date: Tue, 30 Jun 2026 14:45:40 -0700 Subject: [PATCH 3/3] CI: don't block on advisories for the EOL Laravel 10/11 compat jobs composer config policy.advisories.block false before update: Laravel 10/11 pull advisory-affected framework deps that this package doesn't ship, so the compat matrix shouldn't fail resolution on them. --- .github/workflows/tests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 9407d15..87e6f22 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -50,6 +50,9 @@ jobs: - name: Install dependencies run: | + # EOL Laravel 10/11 pull in advisory-affected framework deps; this is a compat + # test matrix (those deps aren't shipped by this package), so don't block on them. + composer config --no-plugins policy.advisories.block false composer update --with "illuminate/support:^${{ matrix.laravel }}.0" --with "illuminate/view:^${{ matrix.laravel }}.0" --with "illuminate/contracts:^${{ matrix.laravel }}.0" --with "orchestra/testbench:^${{ matrix.testbench }}.0" --no-interaction --prefer-dist - name: Run tests