fix: complete Clang-Tidy fixes and move default multicast IP to cpp

Add missing includes across nuclearnet sources, apply empty announce_address
default in reset(), and relocate the multicast literal out of headers for Sonar.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: TrentHouliston

src/nuclearnet/NUClearNet.cpp

@@ -50,6 +50,11 @@ namespace network {
 
 namespace {
 
+    /// Default organization-local multicast address for peer discovery (RFC 2365)
+    const char* default_announce_address() {
+        return "239.226.152.162";  // NOSONAR
+    }
+
     iovec make_iovec(void* base, std::size_t len) {
 #ifdef _WIN32
         iovec iov{};
@@ -135,6 +140,9 @@ namespace {
 
         config    = new_config;
         node_name = new_config.name;
+        if (config.announce_address.empty()) {
+            config.announce_address = default_announce_address();
+        }
 
         // Update module configurations
         discovery     = std::make_unique<Discovery>(new_config.peer_timeout);

src/nuclearnet/NUClearNet.hpp

@@ -41,7 +41,6 @@
 #include "PacketDeduplicator.hpp"
 #include "Reliability.hpp"
 #include "Routing.hpp"
-#include "wire_protocol.hpp"
 
 namespace NUClear {
 namespace network {
@@ -52,8 +51,8 @@ namespace network {
     struct NetworkConfig {
         /// This node's name on the network
         std::string name;
-        /// The multicast/broadcast/unicast address to announce on
-        std::string announce_address = default_announce_address();
+        /// The multicast/broadcast/unicast address to announce on (empty = default organization-local multicast)
+        std::string announce_address;
         /// The port to use for announce discovery
         in_port_t announce_port = 7447;
         /// Address to bind to (empty = all interfaces)

src/nuclearnet/RTTEstimator.cpp

@@ -24,6 +24,7 @@
 #include "RTTEstimator.hpp"
 
 #include <algorithm>
+#include <chrono>
 #include <cmath>
 
 namespace NUClear {

src/nuclearnet/Reliability.cpp

@@ -25,7 +25,11 @@
 #include "Reliability.hpp"
 
 #include <algorithm>
+#include <chrono>
+#include <cstdint>
 #include <cstring>
+#include <mutex>
+#include <vector>
 
 #include "wire_protocol.hpp"
 

src/nuclearnet/Routing.cpp

@@ -22,6 +22,11 @@
 
 #include "Routing.hpp"
 
+#include <cstdint>
+#include <mutex>
+#include <utility>
+#include <vector>
+
 namespace NUClear {
 namespace network {
 

src/nuclearnet/wire_protocol.hpp

@@ -41,11 +41,6 @@ namespace network {
     /// Protocol version for NUClearNet v2
     constexpr uint8_t PROTOCOL_VERSION = 0x03;
 
-    /// Default organization-local multicast address for peer discovery (RFC 2365)
-    inline const char* default_announce_address() {
-        return "239.226.152.162";  // NOSONAR
-    }
-
     /// Packet type identifiers
     enum PacketType : uint8_t {
         ANNOUNCE = 1,