Skip to content

Review forge lint "unsafe-typecast" #556

Description

@wjmelements

My brief examination found these were all false positives, but as a follow-up to #555, we want to look over them to see if any are worth fixing. In some cases these truncations are intentional. In other cases they are harmless.

Do not add guards against impossible situations.

Assume that parameters supplied by the owner will be reasonable, though certain footguns may still be worth protecting against, depending on the impact.

Do not change function signatures.

Prefer to leave this lint disabled if there are more than 2 false-positives remaining in the codebase, rather than proliferating forge-lint: disable-next-line(unsafe-typecast).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    Status
    📌 Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions