Skip to content

Commit 281f11f

Browse files
authored
fix(CI): Run CI tests against the expected .NET version (#182)
1 parent a985f6b commit 281f11f

3 files changed

Lines changed: 6 additions & 13 deletions

File tree

.github/workflows/formatting-and-tests.yml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
max-parallel: 4
4040
matrix:
4141
working-directory: ["Flagsmith.EngineTest","Flagsmith.Client.Test"]
42-
dotnet-version: ["6.x", "7.x", "8.x", "9.x", "10.x"]
42+
dotnet-version: ["6.0", "7.0", "8.0", "9.0", "10.0"]
4343

4444
steps:
4545
- name: Cloning repo
@@ -52,17 +52,10 @@ jobs:
5252
run: make clone-engine-test-data
5353

5454
- name: Set up Dotnet ${{ matrix.dotnet-version }}
55-
uses: actions/setup-dotnet@v3
55+
uses: actions/setup-dotnet@v4
5656
with:
57-
dotnet-version: |
58-
6.0.x
59-
${{ matrix.dotnet-version }}
57+
dotnet-version: ${{ matrix.dotnet-version }}.x
6058

6159
- name: Run Tests
62-
# bafflingly adding the below debugging echo / version statements got the workflow to pass
63-
run: |
64-
echo "Dotnet version: "
65-
dotnet --version
66-
echo "-------"
67-
dotnet test
60+
run: dotnet test --framework net${{ matrix.dotnet-version }}
6861
working-directory: ${{ matrix.working-directory }}

Flagsmith.Client.Test/ClientTest.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net6.0</TargetFramework>
4+
<TargetFrameworks>net6.0;net7.0;net8.0;net9.0;net10.0</TargetFrameworks>
55

66
<IsPackable>false</IsPackable>
77
</PropertyGroup>

Flagsmith.EngineTest/EngineTest.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net6.0</TargetFramework>
4+
<TargetFrameworks>net6.0;net7.0;net8.0;net9.0;net10.0</TargetFrameworks>
55

66
<IsPackable>false</IsPackable>
77

0 commit comments

Comments
 (0)