API replace does not delete original file

[markcs]

Has anyone seen that when using the API /files/replace and setting deleteNewFile to true, the original file is still not deleted from storage.

Is that by design and how to delete the file?

[Forceu]

Thank you for the report! Indeed that was not intentional, but with the current version, it the source file on the storage would have been deleted within one hour or if Gokapi restarts.

I have changed this in 7bd4405, so now it will be deleted right away.

[markcs]

Thanks!
I pulled the latest changes and build the docker, but the file is not deleted.

sqlite> select * from FileMetaData;
UgKwBYzhfhOme3l|work.ics|993.9 kB|58a913238a034651052aab3303461dbcb94d600a|1779925652|1017737|0|184|||text/calendar||_EncryptionInfo��|1|1|1|1778716052|0|
sqlite> 

$ ls -l
total 4276
-rw------- 1 root root 1017737 May 19 21:30 58a913238a034651052aab3303461dbcb94d600a
-rw------- 1 root root 1017737 May 19 21:24 be3fe6d81bec41bf09314cb0385103e108e39ea9
-rw-r--r-- 1 root root   81920 May 19 21:12 gokapi.sqlite
-rw-r--r-- 1 root root   32768 May 19 21:34 gokapi.sqlite-shm
-rw-r--r-- 1 root root  354352 May 19 21:34 gokapi.sqlite-wal
-rw------- 1 root root 1857089 May 19 21:30 log.txt

$ ls -l
total 5336
-rw------- 1 root root 1017737 May 19 21:30 58a913238a034651052aab3303461dbcb94d600a
-rw------- 1 root root 1017738 May 19 21:37 6ea6eb3fa852ee4ae923e56910a820fd628107fc
-rw------- 1 root root 1017737 May 19 21:24 be3fe6d81bec41bf09314cb0385103e108e39ea9
-rw-r--r-- 1 root root   81920 May 19 21:12 gokapi.sqlite
-rw-r--r-- 1 root root   32768 May 19 21:37 gokapi.sqlite-shm
-rw-r--r-- 1 root root  420272 May 19 21:37 gokapi.sqlite-wal
-rw------- 1 root root 1857333 May 19 21:37 log.txt
$ sqlite3 gokapi.sqlite 
SQLite version 3.45.1 2024-01-30 16:01:20
Enter ".help" for usage hints.
sqlite> select * from FileMetaData;
UgKwBYzhfhOme3l|work.ics|993.9 kB|6ea6eb3fa852ee4ae923e56910a820fd628107fc|1779925652|1017738|0|184|||text/calendar||_EncryptionInfo��|1|1|1|1778716052|0|
sqlite> 

[Forceu]

Thanks for the feedback. Let's continue this this in #407, as Issues make it a bit easier to follow than Discussions.