Unable to open 006-flux.html

[ramh]

When I try to open 006-flux.html I get the following error in Chrome, after clicking on "Add recipe".

[JavascriptMick]

+1 same issue

I tried adding a storeDidChange function to my Store but it is ignored by mcFly

    var RecipeStore = Flux.createStore({
        getRecipes: function(){
           return _recipes;
        },
        storeDidChange: function(){
            return true;
        }... etc...

Seems to be related to this pull in McFly...
Pull: kenwheeler/mcfly#32
Commit: kenwheeler/mcfly@caca2cd

[colinmegill]

@kenwheeler same issue? everyone, try switching to onChange?

On Sunday, February 22, 2015, Michael Dausmann notifications@github.com
wrote:

+1 same issue

I tried adding a storeDidChange function to my Store but it is ignored by
mcFly

var RecipeStore = Flux.createStore({
    getRecipes: function(){
       return _recipes;
    },
    storeDidChange: function(){
        return true;
    }... etc...

Seems to be related to this pull in McFly...
Pull: kenwheeler/mcfly#32 kenwheeler/mcfly#32
Commit: kenwheeler/mcfly@caca2cd
kenwheeler/mcfly@caca2cd

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

[JavascriptMick]

using an onChange doesn't' seem to work either..
I think the problem is within the Store constructor in McFly. even though the passed in methods argument seems to have my configured method (storeDidChange, onChange etc), within the mixin object littoral, the this instance doesn't reference them..

function Store(methods, callback) {
var self = this;
this.callback = callback;
iv(!methods.callback, '"callback" is a reserved name and cannot be used as a method name.');
iv(!methods.mixin,'"mixin" is a reserved name and cannot be used as a method name.');
assign(this, EventEmitter.prototype, methods);
this.mixin = {
componentDidMount: function() {... within the mixin littoral, this does not have storeDidChange... therefore changeFn does not get assigned

[weske]

Just came across the same issue. There is actually a typo in changeset af7e113 inside RecipesController: stateDidChange should be storeDidChange (like the comment for the change says).

[JavascriptMick]

Nice find weske. confirm this fixes the problem.