Skip to content

bug: Non-normalized state parameter for auth redirects may cause auth flow to fail #443

@FoxxMD

Description

@FoxxMD

Please check existing knowledge before opening an issue

Describe the Bug

RE #441 -- since MS uses source/client names for state parameter in callback uris, it's possible that non-normal values (containing spaces or non ascii characters) are either 1) not allowed by auth services 2) not correctly encoded into query string. We should refactor auth url building to normalize these values and then correctly compare them on auth redirect, to eliminate this possibility.

Platform

Docker

Versions

All

Logs

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions