Offline sync sometimes spends a long time synchronising ... nothing?

[lexbailey]

I'm not sure how to reproduce this issue 😅

I recently logged in to my instance on a computer that hadn't logged in for a while, and the list of reviews was empty.
The "Uploading data from offline sessions" heading appeared, and regularly flashed, about once per second.

After a bit of poking around, it looks like it had queued up a whole bunch of list-comments requests, and was sending them one after the other.

The list is hundreds of items long, and it does one per second. I still have a ten minute wait before this queue clears

So, I guess there's two issues here:

1. Offline sync prevents the review list loading, meaning a long wait for the user to get to a review
2. Offline sync queues list-comments requests when it should really just forget about them? (at least I think that's what's happening)

[lexbailey]

Mainly for me to find when I next hit this...

A workaround is to paste this into the developer console when the slow sync is happening:

new Server().db.todo.where("attempts").below(20).delete()

Which deletes all of the items that the offline sync logic wants to send to the server (and may result in a loss of data)

[Franchie]

Yes agreed, the logic should be a bit smarter in terms of what items need to be stored for offline-online replay, vs what can be dropped.