fix(agent-tools): remove read freshness gating

Remove session-scoped Read freshness checks from Edit and Write,
including state recording, mutation backfills, and obsolete contracts.
Keep prompt guidance requiring agents to read files before editing.

The gate cannot correct an inaccurate old_string. It adds rejection
conditions beyond content matching: changes outside the target block
can invalidate an otherwise applicable edit, while rollback or context
replacement clears cached reads. Since the state is memory-only,
restarting also loses Read records even when the restored conversation
still contains the relevant file content.

This follows established approaches in Codex and OpenCode:
- Codex apply_patch reads current file content and matches patch context
  without requiring session-scoped prior-Read credentials.
- OpenCode previously tracked read timestamps, mtime, and size per
  session and path, rejecting edits and overwrites without a prior Read
  or after metadata changes. Commit 76a141090, "chore: delete filetime
  module (#22999)", removed that module, its Read/Edit/Write integration,
  the disable-check flag, and associated tests.
- Current OpenCode edit and apply_patch match against current content;
  write likewise has no runtime prior-Read gate.

Preserve Deep Review range receipts in a separate store, including
their session cleanup behavior. Improve old_string mismatch errors
to mention external changes or incorrectly copied or generated text,
retain nearby-content diagnostics, and direct agents to Read the
current target region before correcting the edit and retrying.

Author: wsp1911

scripts/core-boundaries/rules/source/forbidden-rules.mjs

@@ -1665,22 +1665,27 @@ export const forbiddenContentRules = [
     ],
   },
   {
-    path: 'src/crates/assembly/core/src/agentic/session/file_read_state.rs',
+    path: 'src/crates/assembly/core/src/agentic/session/review_read_receipt.rs',
     patterns: [
       {
-        regex: /\bpub struct FileReadState\b/,
+        regex: /\bpub struct FileRevision\b/,
         message:
-          'core file_read_state must not own file-read state DTOs; use openbitfun-agent-runtime file_read_state',
+          'core review_read_receipt must not own file revision DTOs; use openbitfun-agent-runtime review_read_receipt',
       },
       {
-        regex: /\bpub struct FileReadStateStore\b/,
+        regex: /\bpub struct ReviewReadCoverage\b/,
         message:
-          'core file_read_state must not own in-memory file-read state store; use openbitfun-agent-runtime file_read_state',
+          'core review_read_receipt must not own review coverage DTOs; use openbitfun-agent-runtime review_read_receipt',
+      },
+      {
+        regex: /\bpub struct ReviewReadReceiptStore\b/,
+        message:
+          'core review_read_receipt must not own the receipt store; use openbitfun-agent-runtime review_read_receipt',
       },
       {
         regex: /\bDashMap\b/,
         message:
-          'core file_read_state must not own file-read state storage maps; use openbitfun-agent-runtime file_read_state',
+          'core review_read_receipt must not own receipt storage maps; use openbitfun-agent-runtime review_read_receipt',
       },
     ],
   },
@@ -2715,12 +2720,12 @@ export const forbiddenContentRules = [
     ],
   },
   {
-    path: 'src/crates/assembly/core/src/agentic/tools/file_read_state_runtime.rs',
+    path: 'src/crates/assembly/core/src/agentic/tools/review_read_receipt_runtime.rs',
     patterns: [
       {
         regex: /framework::(?:\{[^}]*\bToolUseContext\b[^}]*\}|\bToolUseContext\b)/,
         message:
-          'file read-state runtime must import ToolUseContext from tool_context_runtime, not the framework re-export',
+          'review read receipt runtime must import ToolUseContext from tool_context_runtime, not the framework re-export',
       },
     ],
   },
@@ -3047,16 +3052,6 @@ export const forbiddenContentRules = [
       },
     ],
   },
-  {
-    path: 'src/crates/assembly/core/src/agentic/tools/file_read_state_runtime.rs',
-    patterns: [
-      {
-        regex: /\bnormalize_string\b/,
-        message:
-          'core file read-state runtime must delegate pure freshness normalization to openbitfun-agent-tools',
-      },
-    ],
-  },
   {
     path: 'src/crates/assembly/core/src/agentic/tools/tool_result_storage.rs',
     patterns: [

scripts/core-boundaries/rules/source/public-api-rules.mjs

@@ -30,7 +30,7 @@ export const agentRuntimeRootPublicModules = [
   'event_source',
   'events',
   'evidence_ledger',
-  'file_read_state',
+  'review_read_receipt',
   'native_hooks',
   'output_surface',
   'permission',

scripts/core-boundaries/rules/source/required-rules.mjs

@@ -975,29 +975,29 @@ export const requiredContentRules = [
     ],
   },
   {
-    path: 'src/crates/execution/agent-runtime/src/file_read_state.rs',
+    path: 'src/crates/execution/agent-runtime/src/review_read_receipt.rs',
     reason:
-      'agent-runtime must own provider-neutral file-read state facts and session-scoped in-memory store',
+      'agent-runtime must own provider-neutral code-review read receipts and their session-scoped in-memory store',
     patterns: [
       {
-        regex: /\bpub struct FileReadState\b/,
-        message: 'missing agent-runtime file-read state DTO',
+        regex: /\bpub struct FileRevision\b/,
+        message: 'missing agent-runtime file revision DTO',
       },
       {
-        regex: /\bpub fn is_full_file_read\b/,
-        message: 'missing agent-runtime file-read completeness policy',
+        regex: /\bpub struct ReviewReadCoverage\b/,
+        message: 'missing agent-runtime review read coverage DTO',
       },
       {
-        regex: /\bpub struct FileReadStateStore\b/,
-        message: 'missing agent-runtime file-read state store',
+        regex: /\bpub struct ReviewReadReceiptStore\b/,
+        message: 'missing agent-runtime review read receipt store',
       },
       {
-        regex: /\bfile_read_state_accepts_nonempty_whole_file\b/,
-        message: 'missing agent-runtime file-read completeness regression',
+        regex: /\breview_read_receipt_store_scopes_entries_by_session\b/,
+        message: 'missing review read receipt session scoping regression',
       },
       {
-        regex: /\bfile_read_state_store_scopes_entries_by_session\b/,
-        message: 'missing agent-runtime file-read state session scoping regression',
+        regex: /\breview_read_receipt_covers_only_previously_returned_lines\b/,
+        message: 'missing review read receipt coverage regression',
       },
     ],
   },
@@ -2853,14 +2853,17 @@ export const requiredContentRules = [
     ],
   },
   {
-    path: 'src/crates/assembly/core/src/agentic/session/file_read_state.rs',
+    path: 'src/crates/assembly/core/src/agentic/session/review_read_receipt.rs',
     reason:
-      'core file_read_state path must stay a compatibility facade over agent-runtime',
+      'core review_read_receipt path must stay a compatibility facade over agent-runtime',
     patterns: [
       {
-        regex:
-          /pub use openbitfun_agent_runtime::file_read_state::\{FileReadState, FileReadStateStore\};/,
-        message: 'missing agent-runtime file-read state compatibility re-export',
+        regex: /openbitfun_agent_runtime::review_read_receipt::\{/,
+        message: 'missing agent-runtime review read receipt compatibility re-export',
+      },
+      {
+        regex: /\bReviewReadReceiptStore\b/,
+        message: 'missing review read receipt store compatibility re-export',
       },
     ],
   },
@@ -5629,28 +5632,6 @@ export const requiredContentRules = [
       },
     ],
   },
-  {
-    path: 'src/crates/execution/tool-contracts/src/file_read_freshness.rs',
-    reason: 'agent-tools owns pure file-read freshness policy for Read/Edit/Write guardrails',
-    patterns: [
-      {
-        regex: /\bpub struct FileReadFreshnessFacts\b/,
-        message: 'missing file-read freshness facts contract',
-      },
-      {
-        regex: /\bpub fn normalize_tool_file_content\b/,
-        message: 'missing provider-neutral file content normalization helper',
-      },
-      {
-        regex: /\bpub fn file_read_facts_content_matches\b/,
-        message: 'missing file-read content equivalence helper',
-      },
-      {
-        regex: /\bpub fn file_read_facts_are_fresh\b/,
-        message: 'missing file-read freshness policy helper',
-      },
-    ],
-  },
   {
     path: 'src/crates/execution/tool-contracts/src/tool_result_storage.rs',
     reason:

scripts/core-boundaries/self-test.mjs

@@ -2368,12 +2368,17 @@ export function runManifestParserSelfTest({
   ) {
     throw new Error('agentic system boundary rule must forbid terminal provider construction');
   }
-  const coreFileReadStateRuleText = forbiddenRuleTextForPath(
-    'src/crates/assembly/core/src/agentic/session/file_read_state.rs',
+  const coreReviewReadReceiptRuleText = forbiddenRuleTextForPath(
+    'src/crates/assembly/core/src/agentic/session/review_read_receipt.rs',
   );
-  for (const contract of ['FileReadState', 'FileReadStateStore', 'DashMap']) {
-    if (!coreFileReadStateRuleText.includes(contract)) {
-      throw new Error(`core file_read_state boundary rule must forbid ${contract}`);
+  for (const contract of [
+    'FileRevision',
+    'ReviewReadCoverage',
+    'ReviewReadReceiptStore',
+    'DashMap',
+  ]) {
+    if (!coreReviewReadReceiptRuleText.includes(contract)) {
+      throw new Error(`core review_read_receipt boundary rule must forbid ${contract}`);
     }
   }
   const coreEvidenceLedgerRuleText = forbiddenRuleTextForPath(
@@ -3180,13 +3185,13 @@ export function runManifestParserSelfTest({
       ],
     },
     {
-      path: 'src/crates/execution/agent-runtime/src/file_read_state.rs',
+      path: 'src/crates/execution/agent-runtime/src/review_read_receipt.rs',
       contracts: [
-        'FileReadState',
-        'is_full_file_read',
-        'FileReadStateStore',
-        'file_read_state_accepts_nonempty_whole_file',
-        'file_read_state_store_scopes_entries_by_session',
+        'FileRevision',
+        'ReviewReadCoverage',
+        'ReviewReadReceiptStore',
+        'review_read_receipt_store_scopes_entries_by_session',
+        'review_read_receipt_covers_only_previously_returned_lines',
       ],
     },
     {
@@ -3643,15 +3648,6 @@ export function runManifestParserSelfTest({
         'is_file_tool_guidance_message',
       ],
     },
-    {
-      path: 'src/crates/execution/tool-contracts/src/file_read_freshness.rs',
-      contracts: [
-        'FileReadFreshnessFacts',
-        'normalize_tool_file_content',
-        'file_read_facts_content_matches',
-        'file_read_facts_are_fresh',
-      ],
-    },
     {
       path: 'src/crates/execution/tool-contracts/src/tool_result_storage.rs',
       contracts: [

src/crates/assembly/core/src/agentic/session/file_read_state.rs

@@ -6,9 +6,9 @@ pub mod compression;
 pub mod context_store;
 mod context_usage;
 pub mod evidence_ledger;
-pub mod file_read_state;
 pub mod prompt_cache;
 pub(crate) mod revert;
+pub mod review_read_receipt;
 pub mod session_manager;
 pub mod session_store_port;
 pub mod token_anchor;
@@ -19,8 +19,8 @@ pub use compression::*;
 pub use context_store::*;
 pub use context_usage::*;
 pub use evidence_ledger::*;
-pub use file_read_state::*;
 pub use prompt_cache::*;
+pub use review_read_receipt::*;
 pub use session_manager::*;
 pub use session_store_port::*;
 pub use token_anchor::*;

src/crates/assembly/core/src/agentic/session/mod.rs

@@ -0,0 +1,5 @@
+//! Compatibility facade for session-scoped code-review read receipts.
+
+pub use openbitfun_agent_runtime::review_read_receipt::{
+    FileRevision, ReviewReadCoverage, ReviewReadReceiptStore,
+};