Merge pull request #2844 from bobleer/bob/remote-target-label-consistency

fix(nav): prefer connection aliases in remote workspace badges

Author: bobleer

src/web-ui/src/app/components/NavPanel/sections/workspaces/WorkspaceItem.tsx

@@ -252,7 +252,7 @@ const WorkspaceItem: React.FC<WorkspaceItemProps> = ({
     return {
       status,
       statusLabel,
-      hostLabel,
+      connectionLabel,
       /** A green dot already reads as "fine"; spell out only the states that need attention. */
       showStatusText: status !== 'connected',
       tooltip: t('nav.workspaces.remote.tooltip', {
@@ -261,7 +261,7 @@ const WorkspaceItem: React.FC<WorkspaceItemProps> = ({
         status: statusLabel,
       }),
       ariaLabel: t('nav.workspaces.remote.ariaLabel', {
-        connection: hostLabel,
+        connection: connectionLabel,
         status: statusLabel,
       }),
     };
@@ -1362,7 +1362,7 @@ const WorkspaceItem: React.FC<WorkspaceItemProps> = ({
                       aria-hidden="true"
                     />
                     <span className="openbitfun-nav-panel__workspace-item-remote-host">
-                      {remoteMeta.hostLabel}
+                      {remoteMeta.connectionLabel}
                     </span>
                     {remoteMeta.showStatusText ? (
                       <span className="openbitfun-nav-panel__workspace-item-remote-status">

src/web-ui/src/app/components/NavPanel/sections/workspaces/WorkspaceListSectionLayout.test.ts

@@ -222,7 +222,7 @@ describe('WorkspaceListSection layout styles', () => {
     expect(source).toContain('behavior="marquee"');
     expect(searchIndicatorStart).toBeGreaterThan(remoteNameStart);
     expect(remoteMetaStart).toBeGreaterThan(searchIndicatorStart);
-    expect(remoteMetaMarkup).toContain('remoteMeta.hostLabel');
+    expect(remoteMetaMarkup).toContain('remoteMeta.connectionLabel');
     expect(remoteMetaMarkup.indexOf('workspace-item-status-dot'))
       .toBeLessThan(remoteMetaMarkup.indexOf('workspace-item-remote-host'));
     expect(source).not.toContain('workspace-item-subtitle');