Skip to content

fix: apply pending code review — remove redundant lambdas, fix parse_event_time dict handling, bump to v1.2.3#37

Merged
Geek-MD merged 2 commits into
mainfrom
copilot/fix-manifest-json-changelog
Mar 15, 2026
Merged

fix: apply pending code review — remove redundant lambdas, fix parse_event_time dict handling, bump to v1.2.3#37
Geek-MD merged 2 commits into
mainfrom
copilot/fix-manifest-json-changelog

Conversation

Copilot AI commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

Two unaddressed code review comments from PRs #35 and #36 were never applied before merging, leaving manifest.json and CHANGELOG.md out of sync with the actual code state.

Changes

  • helpers.pyparse_event_time now accepts a full event dict (extracts "time" key) in addition to datetime/string, making it safe to use directly as a sort key= function on event lists
  • sensor.py — Removed redundant lambda wrappers at both sorted() call sites:
    # Before
    key=lambda e: parse_event_time(e)
    # After
    key=parse_event_time
  • manifest.json — Version bumped 1.2.21.2.3
  • CHANGELOG.md — Added v1.2.3 entry documenting the above fixes

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…hangelog

Co-authored-by: Geek-MD <25725990+Geek-MD@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix manifest.json and changelog in previous merge fix: apply pending code review — remove redundant lambdas, fix parse_event_time dict handling, bump to v1.2.3 Mar 15, 2026
Copilot AI requested a review from Geek-MD March 15, 2026 22:01
@Geek-MD Geek-MD marked this pull request as ready for review March 15, 2026 22:06
@Geek-MD Geek-MD merged commit b374b68 into main Mar 15, 2026
3 checks passed
@Geek-MD Geek-MD deleted the copilot/fix-manifest-json-changelog branch March 15, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants