From 16c2fe365147a7c0924240d46b018dadd43c25f0 Mon Sep 17 00:00:00 2001 From: "seer-by-sentry[bot]" <157164994+seer-by-sentry[bot]@users.noreply.github.com> Date: Wed, 24 Dec 2025 23:01:10 +0000 Subject: [PATCH] OnlineServices: Pass LobbyMemberEntry by const reference in PlayerDoesntHaveMap callback --- .../GeneralsOnline/OnlineServices_LobbyInterface.h | 4 ++-- .../GameClient/GUI/GUICallbacks/Menus/WOLGameSetupMenu.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/GeneralsMD/Code/GameEngine/Include/GameNetwork/GeneralsOnline/OnlineServices_LobbyInterface.h b/GeneralsMD/Code/GameEngine/Include/GameNetwork/GeneralsOnline/OnlineServices_LobbyInterface.h index 1e525e58e1f..b3455acf03c 100644 --- a/GeneralsMD/Code/GameEngine/Include/GameNetwork/GeneralsOnline/OnlineServices_LobbyInterface.h +++ b/GeneralsMD/Code/GameEngine/Include/GameNetwork/GeneralsOnline/OnlineServices_LobbyInterface.h @@ -325,8 +325,8 @@ class NGMP_OnlineServices_LobbyInterface void UpdateRoomDataCache(std::function fnCallback = nullptr); - std::function m_cbPlayerDoesntHaveMap = nullptr; - void RegisterForPlayerDoesntHaveMapCallback(std::function cb) + std::function m_cbPlayerDoesntHaveMap = nullptr; + void RegisterForPlayerDoesntHaveMapCallback(std::function cb) { m_cbPlayerDoesntHaveMap = cb; } diff --git a/GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLGameSetupMenu.cpp b/GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLGameSetupMenu.cpp index ef91fdb2836..c36f3775688 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLGameSetupMenu.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLGameSetupMenu.cpp @@ -1774,7 +1774,7 @@ void WOLGameSetupMenuInit( WindowLayout *layout, void *userData ) } // player doesnt have map events - pLobbyInterface->RegisterForPlayerDoesntHaveMapCallback([](LobbyMemberEntry lobbyMember) + pLobbyInterface->RegisterForPlayerDoesntHaveMapCallback([](const LobbyMemberEntry& lobbyMember) { // tell the host the user doesn't have the map UnicodeString mapDisplayName;