From afcd8b3305041d682ed60575f61c7518367706ba Mon Sep 17 00:00:00 2001 From: "seer-by-sentry[bot]" <157164994+seer-by-sentry[bot]@users.noreply.github.com> Date: Sun, 28 Dec 2025 12:40:52 +0000 Subject: [PATCH] Refactor: Adjust scope and initialization of `doAnimation` variable during veterancy update --- GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp index bca7c39b872..9bd5991d887 100644 --- a/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp +++ b/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp @@ -3139,6 +3139,8 @@ void Object::onVeterancyLevelChanged( VeterancyLevel oldLevel, VeterancyLevel ne if (body) body->onVeterancyLevelChanged( oldLevel, newLevel, provideFeedback ); + Bool doAnimation = FALSE; + switch (newLevel) { case LEVEL_REGULAR: @@ -3175,7 +3177,7 @@ void Object::onVeterancyLevelChanged( VeterancyLevel oldLevel, VeterancyLevel ne break; } - Bool doAnimation = provideFeedback + doAnimation = provideFeedback && newLevel > oldLevel && !isKindOf(KINDOF_IGNORED_IN_GUI) && isLogicallyVisible();