Summary
The repository-wide lint command currently reports 35 pre-existing findings:
- 27
staticcheck findings
- 6
unused findings
- 2
ineffassign findings
These findings are unrelated to PR #725, but prevent contributors from completing the mandatory lint check with a clean result.
Reproduction
Because of the toolchain problem tracked in #680, explicitly select Go 1.26.5:
$env:GOTOOLCHAIN = 'go1.26.5'
go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2 run --enable-only unused,ineffassign,staticcheck ./...
Findings
ineffassign
internal/cli/mcp_config.go:737
internal/cli/mcp_config.go:744
unused
internal/sandbox/runner.go:385 - existingBubblewrapMounts
internal/sandbox/runner.go:795 - denyWriteRules
internal/sandbox/runner.go:827 - networkRuleFor
internal/tui/model.go:2950 - model.scrollableTranscriptView
internal/tui/streaming_fade.go:284 - model.ensureAgeTickReschedule
internal/tui/transcript_selection.go:1278 - transcriptViewportStartForLayout
staticcheck
internal/agenteval/score.go:128 (S1011)
internal/agentinit/agentinit.go:43,48,50 (QF1012)
internal/cli/agent_eval.go:518 (S1011)
internal/cli/provider_detect.go:86 (QF1002)
internal/dictation/transcriber_deepgram.go:103 (ST1005)
internal/lsp/navigate_test.go:67,79 (SA1012)
internal/provideronboarding/localruntime_test.go:65 (S1009)
internal/sandbox/adapters.go:228 (QF1001)
internal/sandbox/command_prefix.go:156 (S1008)
internal/sandbox/engine.go:236 (QF1001)
internal/sandbox/landlock_other.go:7 (ST1005)
internal/sandbox/windows_network.go:13 (ST1005)
internal/specialist/exec.go:830 (QF1008)
internal/tui/files_git_sweep_test.go:195 (SA1012)
internal/tui/model_test.go:1399 (SA4006)
internal/tui/onboarding.go:221,230,282 (QF1003)
internal/tui/provider_wizard_test.go:686 (SA4006)
internal/tui/specialist_card.go:417 (QF1002)
internal/update/apply.go:165 (QF1003)
internal/update/apply_test.go:154 (QF1003)
internal/update/update.go:370 (ST1005)
internal/usercommands/usercommands.go:112 (QF1001)
Expected result
The mandatory lint command exits successfully with no findings.
Context
Observed while validating PR #725 at commit fef6c5d on Windows/amd64. None of the reported files were changed by that commit.
Summary
The repository-wide lint command currently reports 35 pre-existing findings:
staticcheckfindingsunusedfindingsineffassignfindingsThese findings are unrelated to PR #725, but prevent contributors from completing the mandatory lint check with a clean result.
Reproduction
Because of the toolchain problem tracked in #680, explicitly select Go 1.26.5:
Findings
ineffassign
internal/cli/mcp_config.go:737internal/cli/mcp_config.go:744unused
internal/sandbox/runner.go:385-existingBubblewrapMountsinternal/sandbox/runner.go:795-denyWriteRulesinternal/sandbox/runner.go:827-networkRuleForinternal/tui/model.go:2950-model.scrollableTranscriptViewinternal/tui/streaming_fade.go:284-model.ensureAgeTickRescheduleinternal/tui/transcript_selection.go:1278-transcriptViewportStartForLayoutstaticcheck
internal/agenteval/score.go:128(S1011)internal/agentinit/agentinit.go:43,48,50(QF1012)internal/cli/agent_eval.go:518(S1011)internal/cli/provider_detect.go:86(QF1002)internal/dictation/transcriber_deepgram.go:103(ST1005)internal/lsp/navigate_test.go:67,79(SA1012)internal/provideronboarding/localruntime_test.go:65(S1009)internal/sandbox/adapters.go:228(QF1001)internal/sandbox/command_prefix.go:156(S1008)internal/sandbox/engine.go:236(QF1001)internal/sandbox/landlock_other.go:7(ST1005)internal/sandbox/windows_network.go:13(ST1005)internal/specialist/exec.go:830(QF1008)internal/tui/files_git_sweep_test.go:195(SA1012)internal/tui/model_test.go:1399(SA4006)internal/tui/onboarding.go:221,230,282(QF1003)internal/tui/provider_wizard_test.go:686(SA4006)internal/tui/specialist_card.go:417(QF1002)internal/update/apply.go:165(QF1003)internal/update/apply_test.go:154(QF1003)internal/update/update.go:370(ST1005)internal/usercommands/usercommands.go:112(QF1001)Expected result
The mandatory lint command exits successfully with no findings.
Context
Observed while validating PR #725 at commit
fef6c5don Windows/amd64. None of the reported files were changed by that commit.