Prepare to ship with GOS

[RankoR]

• Change package name to org.grapheneos.gallery
• Add deps pinning
• Rename to Gallery
• Use GOS Gallery icon
• Remove "All Files Access" permission
• Clarify that it's a fork
• Test (probably, CTS too)
• Adjust GitHub Actions
• Update README.md

Related issues:

• replace Gallery app os-issue-tracker#48
• [Enhancement] Work with grapheneos to make this a viable replacement for aosp gallery IacobIonut01/ReFra#573

Minor:

• Simplify modifier removing redundant then that caused a lint error IacobIonut01/ReFra#837

PRs:

• Set the new Gallery app as system gallery platform_frameworks_base#348
• Replace AOSP Gallery with the new Gallery app platform_build#84
• Prepared to ship with GOS #2
• Migrate old Gallery to GrapheneOS Gallery platform_packages_apps_Launcher3#73
• Add Gallery to the sources page grapheneos.org#1511

[blind-confused]

(I apologize if this ain't the place for suggestions)
considerin that it's a fork, I rly hope it's default icon could be replaced with the current GrapheneOS Gallery icon or somethin similar, their current icon doesn't resemble a gallery that much, and usin the Graphene icon would make it fit in much better with the other stock apps

[inthewaves]

Perhaps we can include TEST_MAPPING with all the CTS tests we validate with to the eventual external/Gallery repo: https://source.android.com/docs/core/tests/development/test-mapping

Then running all the tests is as easy as atest --test-mapping external/Gallery

[inthewaves]

Sample TEST_MAPPING file, adjust as needed. I also included some other CTS tests I found like android.permissionui.cts.MediaPermissionTest#testGalleryAppListedAsFixed

{
  "presubmit": [
    {
      "name": "CtsStorageHostTestCases",
      "options": [
        {
          "include-filter": "android.appsecurity.cts.ExternalStorageHostTest#testSystemGalleryExists"
        }
      ]
    },
    {
      "name": "CtsRoleTestCases",
      "options": [
        {
          "include-filter": "android.app.role.cts.RoleControllerManagerTest#systemGalleryRoleIsNotVisible"
        }
      ]
    },
    {
      "name": "CtsPermissionUiTestCases",
      "options": [
        {
          "include-filter": "android.permissionui.cts.MediaPermissionTest#testGalleryAppListedAsFixed"
        }
      ]
    },
    {
      "name": "CtsOsTestCases",
      "options": [
        {
          "include-filter": "android.os.cts.StrictModeTest#testFileUriExposure"
        },
        {
          "include-filter": "android.os.cts.StrictModeTest#testVmPenaltyListener"
        },
        {
          "include-filter": "android.os.cts.StrictModeTest#testContentUriWithoutPermission"
        }
      ]
    },
    {
      "name": "CtsHibernationTestCases",
      "options": [
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testPreMinAutoRevokeVersionUnusedApp_doesntGetPermissionRevoked"
        },
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testPermissionEventCleanupService_scrubsEvents"
        },
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testAutoRevoke_userAllowlisting"
        },
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testUnusedApp_uninstallApp"
        },
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testInstallGrants_notRevokedImmediately"
        },
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testAppWithPermissionsChangedRecently_doesNotGetPermissionRevoked"
        },
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testUnusedApp_getsPermissionRevoked"
        },
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testAutoRevoke_allowlistingApis"
        },
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testUnusedApp_doesntGetSplitPermissionRevoked"
        },
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testUsedApp_doesntGetPermissionRevoked"
        },
        {
          "include-filter": "android.hibernation.cts.AutoRevokeTest#testAutoRevoke_showsUpInSafetyCenter"
        }
      ]
    },
    {
      "name": "CtsMediaProviderTestCases",
      "options": [
        {
          "include-filter": "android.provider.cts.media.MediaStoreTest#testIsCurrentSystemGallery"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testPickImageDir[0]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testPickImageDir[1]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testPickVideoDir[0]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testPickVideoDir[1]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testPickAudioDir[0]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testPickAudioDir[1]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testViewImageDir[0]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testViewImageDir[1]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testViewVideoDir[0]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testViewVideoDir[1]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testViewImageFile[0]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testViewImageFile[1]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testViewVideoFile[0]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testViewVideoFile[1]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testViewAudioFile[0]"
        },
        {
          "include-filter": "android.provider.cts.media.MediaStoreIntentsTest#testViewAudioFile[1]"
        }
      ]
    },
    {
      "name": "CtsModernMediaProviderTests",
      "options": [
        {
          "include-filter": "android.provider.cts.media.modern.MediaStoreTest#testIsCurrentSystemGallery"
        }
      ]
    },
    {
      "name": "CtsScopedStorageGeneralTest",
      "options": [
        {
          "include-filter": "android.scopedstorage.cts.general.ScopedStorageDeviceTest"
        }
      ]
    },
    {
      "name": "CtsScopedStorageBypassDatabaseOperationsTest",
      "options": [
        {
          "include-filter": "android.scopedstorage.cts.bypassdatabase.BypassDatabaseOperationsTest"
        }
      ]
    },
    {
      "name": "CtsScopedStorageHostTest",
      "options": [
        {
          "include-filter": "android.scopedstorage.cts.host.LegacyStorageHostTest#testLegacySystemGalleryCanRenameImagesAndVideosWithoutDbUpdates"
        },
        {
          "include-filter": "android.scopedstorage.cts.host.LegacyStorageHostTest#testLegacySystemGalleryCanUpdateToExistingDirectory"
        },
        {
          "include-filter": "android.scopedstorage.cts.host.LegacyStorageHostTest#testLegacySystemGalleryWithoutWESCannotRename"
        }
      ]
    }
  ]
}

[RankoR]

@inthewaves just added to GrapheneOS/platform_build#84 (comment)

[twitchyisreal]

What is still holding this back from being merged into GrapheneOS?

[inthewaves]

It takes time to audit a codebase especially for something that would eventually be a default app. We are also focused on Android 17 currently