From 0045a8fe1a9eca2efadcc7824a95b467e55b88d7 Mon Sep 17 00:00:00 2001 From: Mike Virata-Stone Date: Wed, 9 Jul 2025 21:33:14 -0700 Subject: [PATCH 1/2] Attempt to fix error in reconciliations --- app/models/reconciliation_deltas.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/reconciliation_deltas.rb b/app/models/reconciliation_deltas.rb index 6c6b4f3e..e8ee6ead 100644 --- a/app/models/reconciliation_deltas.rb +++ b/app/models/reconciliation_deltas.rb @@ -3,7 +3,7 @@ class ReconciliationDeltas def initialize(reconciliation, items = nil) @reconciliation = reconciliation - @items = items || Item.includes(:category).with_requested_quantity.to_a + @items = items || Item.unscoped.includes(:category).with_requested_quantity.to_a end def each(&block) From 9de51951f0d571094b4e692aa2035d63d835d322 Mon Sep 17 00:00:00 2001 From: Mike Virata-Stone Date: Wed, 9 Jul 2025 21:49:29 -0700 Subject: [PATCH 2/2] Only unscope the items if the reconciliation is complete --- app/models/reconciliation_deltas.rb | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/models/reconciliation_deltas.rb b/app/models/reconciliation_deltas.rb index e8ee6ead..e8ef5af1 100644 --- a/app/models/reconciliation_deltas.rb +++ b/app/models/reconciliation_deltas.rb @@ -3,7 +3,13 @@ class ReconciliationDeltas def initialize(reconciliation, items = nil) @reconciliation = reconciliation - @items = items || Item.unscoped.includes(:category).with_requested_quantity.to_a + item_scope = + if reconciliation.complete? + Item.unscoped + else + Item + end + @items = items || item_scope.includes(:category).with_requested_quantity.to_a end def each(&block)