feat(generate-certs): Generate certs in the ready event (and only once per composeCache (app start)) so that you can also run lando exec without starting first and bump the validity to 10 years

Author: florianPat

app.js

@@ -157,6 +157,9 @@ module.exports = async (app, lando) => {
   // override default tooling commands if needed
   app.events.on('ready', 1, async () => await require('./hooks/app-override-tooling-defaults')(app, lando));
 
+  // Generate certs for v3 SSL services as needed
+  app.events.on('ready', 2, async () => await require('./hooks/app-generate-v3-certs')(app, lando));
+
   // set tooling compose cache
   app.events.on('ready', async () => await require('./hooks/app-set-compose-cache')(app, lando));
 
@@ -190,9 +193,6 @@ module.exports = async (app, lando) => {
   // Check for updates if the update cache is empty
   app.events.on('pre-start', 1, async () => await require('./hooks/app-check-for-updates')(app, lando));
 
-  // Generate certs for v3 SSL services as needed
-  app.events.on('pre-start', 2, async () => await require('./hooks/app-generate-v3-certs')(app, lando));
-
   // If the app already is installed but we can't determine the builtAgainst, then set it to something bogus
   app.events.on('pre-start', async () => await require('./hooks/app-update-built-against-pre')(app, lando));
 

hooks/app-generate-v3-certs.js

@@ -15,6 +15,8 @@ const parseUrls = (urls = []) => {
 };
 
 module.exports = async (app, lando) => {
+  if (lando.cache.get(app.composeCache)) return;
+
   const certServices = app.info
     .filter(service => service.hasCerts === true)
     .map(service => ({

hooks/lando-clean-networks.js

@@ -3,7 +3,10 @@
 // Modules
 const _ = require('lodash');
 
-module.exports = async lando => lando.engine.getNetworks().then(networks => {
+module.exports = async lando => {
+  if (lando.cache.get('_.networks.checked')) return;
+  lando.cache.set('_.networks.checked', true);
+  return lando.engine.getNetworks().then(networks => {
   if (_.size(networks) >= lando.config.networkLimit) {
     // Warn user about this action
     lando.log.warn('Lando has detected you are at Docker\'s network limit!');
@@ -37,3 +40,4 @@ module.exports = async lando => lando.engine.getNetworks().then(networks => {
     });
   }
 });
+};

lib/lando.js

@@ -402,7 +402,7 @@ module.exports = class Lando {
     caKey = this.config.caKey,
     domains = [],
     organization = 'Lando Alliance',
-    validity = 365,
+    validity = 3650,
   } = {}) {
     const read = require('../utils/read-file');
     const write = require('../utils/write-file');