CreateCaloCells vs CreateCaloCellsNoise

[giovannimarchiori]

do we need both
https://github.com/HEP-FCC/k4RecCalorimeter/blob/main/RecCalorimeter/src/components/CreateCaloCells.h
and
https://github.com/HEP-FCC/k4RecCalorimeter/blob/main/RecCalorimeter/src/components/CreateCaloCellsNoise.h
?

They seem to be essentially identical bar
(1) the latter misses cross-talk, added recently by Zhibo
(2) CreateCaloCellsNoise operates on a DataHandleedm4hep::CalorimeterHitCollection
while CreateCaloCells operates on a DataHandleedm4hep::SimCalorimeterHitCollection

If the latter is really needed, then should we add x-talk to it?
Otherwise, can this be put in the dustbin?

Tagging @BrieucF , @faltovaj

[BrieucF]

From the comment in the initial commit of CreateCaloCellsNoise, this one can be used to add noise to calo cells after having created them. It might be useful e.g. to do some noise studies on files in which we did not keep the SimCalorimeterCollection. Not really needed now but I would be in favor of keeping it, for the sake of flexibility.

[giovannimarchiori]

ok. maybe as mentioned in that commit (792b1fe) at some point then we might think how to refactor things to avoid duplicating code

[BrieucF]

I would nevertheless not trigger the development of adding x-talk to CreateCaloCellsNoise as long as we do not need it.

[BrieucF]

ok. maybe as mentioned in that commit at some point then we might think how to refactor things to avoid duplicating code

Yes