diff --git a/src/core/assistant.py b/src/core/assistant.py index f24902b..19c20b6 100644 --- a/src/core/assistant.py +++ b/src/core/assistant.py @@ -1,5 +1,6 @@ # assistant.py import base64 +import os import sqlite3 from langchain_core.messages import HumanMessage @@ -16,6 +17,11 @@ logger = get_logger() +# Ensure parent directory for checkpoints database exists +checkpoint_dir = os.path.dirname(config.CHECKPOINTS_DB) +if checkpoint_dir: + os.makedirs(checkpoint_dir, exist_ok=True) + conn = sqlite3.connect(config.CHECKPOINTS_DB, check_same_thread=False) checkpointer = SqliteSaver(conn) diff --git a/tests/__init__.py b/tests/__init__.py new file mode 100644 index 0000000..65140f2 --- /dev/null +++ b/tests/__init__.py @@ -0,0 +1 @@ +# tests package diff --git a/tests/test_assistant_initialization.py b/tests/test_assistant_initialization.py new file mode 100644 index 0000000..d37d5b1 --- /dev/null +++ b/tests/test_assistant_initialization.py @@ -0,0 +1,54 @@ +"""Tests for assistant initialization and database path directory safeguards.""" + +import os +import sqlite3 +import tempfile +import unittest + +from src.config import config + + +class TestAssistantInitialization(unittest.TestCase): + """Test suite for checkpoint database initialization and directory guards.""" + + def test_checkpoint_dir_creation(self): + """Verifies that creating missing parent directories allows SQLite connection.""" + with tempfile.TemporaryDirectory() as tmpdir: + test_db = os.path.join(tmpdir, "nested_checkpoints", "sqlite.db") + db_dir = os.path.dirname(test_db) + + assert not os.path.exists(db_dir) + + # Without parent directory creation, sqlite3 fails on non-existent directories + failed = False + try: + sqlite3.connect(test_db) + except sqlite3.OperationalError: + failed = True + assert failed + + # Applying the directory guard allows connection to succeed + if db_dir: + os.makedirs(db_dir, exist_ok=True) + + conn = sqlite3.connect(test_db) + assert isinstance(conn, sqlite3.Connection) + conn.close() + assert os.path.exists(test_db) + + def test_config_checkpoints_dir_guard(self): + """Verifies that config.CHECKPOINTS_DB parent directory is created idempotently.""" + db_dir = os.path.dirname(config.CHECKPOINTS_DB) + assert bool(db_dir) + + # Idempotent creation + os.makedirs(db_dir, exist_ok=True) + assert os.path.exists(db_dir) + + conn = sqlite3.connect(config.CHECKPOINTS_DB) + assert isinstance(conn, sqlite3.Connection) + conn.close() + + +if __name__ == "__main__": + unittest.main()