plog and pbands fail to plot drift-mode log files

[vikdhillon]

plog fails when plotting a drift mode log file - no errors are output, but the plot window just shows the axes and no data.

pbands also fails when plotting a drift mode log file - this time with the error given below.

Both commands seem to work ok with non drift-mode log files. Is it perhas something to do with having to set "skipbadt = no" in the reduce .red file when reducing drift mode HiPERCAM data?:

skip points with bad times in plots. HiPERCAM has a problem in not

correctly indicating bad times so one does not usually want to

skip "bad time" points, whereas one should for ULTRACAM and ULTRASPEC.

skipbadt = no

vsd@pulsar/local/vsd/backed_up_on_astro3/frb20200120e/frb_data> pbands
/usr/local/python-3.12/lib/python3.12/site-packages/astropy/config/paths.py:55: AstropyUserWarning: XDG_CONFIG_HOME is set to '/home/vsd/.config', but the default location, /home/vsd/.astropy/config, already exists, and takes precedence. This environment variable will be ignored.
return set_temp_config._get_dir_path(rootname)
log - reduce log file to plot [run0003_nor]: run0009_100k
aper1 - target aperture [1]:
aper2 - comparison aperture ('!' to ignore) [2]:
norm - normalise to median [True]:
zero - set y-axis origin to zero [False]:
pgram - plot periodogram panels too [False]:
title - plot title [run0009_100k.log [median normalised]]:
colours - colours [strings, one per CCD] [('r', 'g', 'k', 'k', 'k')]:
Traceback (most recent call last):
File "/usr/local/python-3.12/bin/pbands", line 6, in
sys.exit(pbands())
^^^^^^^^
File "/usr/local/python-3.12/lib/python3.12/site-packages/hipercam/scripts/pbands.py", line 222, in pbands
_d, y1, _d = targ.percentile(plo, hcam.BAD_TIME | hcam.JUNK)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/python-3.12/lib/python3.12/site-packages/hipercam/hlog.py", line 858, in percentile
y = np.percentile(self.y[good], q)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/python-3.12/lib/python3.12/site-packages/numpy/lib/_function_base_impl.py", line 4246, in percentile
return _quantile_unchecked(
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/python-3.12/lib/python3.12/site-packages/numpy/lib/_function_base_impl.py", line 4510, in _quantile_unchecked
return _ureduce(a,
^^^^^^^^^^^
File "/usr/local/python-3.12/lib/python3.12/site-packages/numpy/lib/_function_base_impl.py", line 3880, in _ureduce
r = func(a, **kwargs)
^^^^^^^^^^^^^^^^^
File "/usr/local/python-3.12/lib/python3.12/site-packages/numpy/lib/_function_base_impl.py", line 4669, in _quantile_ureduce_func
result = _quantile(arr,
^^^^^^^^^^^^^^
File "/usr/local/python-3.12/lib/python3.12/site-packages/numpy/lib/_function_base_impl.py", line 4793, in _quantile
slices_having_nans = np.isnan(arr[-1, ...])
~~~^^^^^^^^^
IndexError: index -1 is out of bounds for axis 0 with size 0
vsd@pulsar/local/vsd/backed_up_on_astro3/frb20200120e/frb_data>

[StuartLittlefair]

Ah - this is because plog and friends don’t plot bad flags by default and all the times in the log file are probably marked as bad (this is normal for drift mode IIRC).

We’ll need to make this flagging behaviour optional

[StuartLittlefair]

Closed by #171