Refactor of _location data structure#11
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 95.46% 95.33% -0.13%
==========================================
Files 4 4
Lines 772 772
Branches 444 442 -2
==========================================
- Hits 737 736 -1
Misses 2 2
- Partials 33 34 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Change paths in capiocl::engine from std::string to std::filesystem::paths. Fixed python bindings.
17a3819 to
1a8a2f2
Compare
df0e41e to
2082525
Compare
2082525 to
4fdb562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the structure of the capiocl::Engine::_locations, by removing the entry tuple and replacing with a more understandable struct. It also updates the logic of the capiocl::Engine class to use the new format of the _location hashmap