From 5194528fc8703c7b3d4444a21da95fc454967a56 Mon Sep 17 00:00:00 2001
From: hshum <hshum@users.noreply.github.com>
Date: Thu, 16 Jul 2026 21:57:11 -0700
Subject: [PATCH] ci: align visual evidence with one surface

---
 .github/workflows/dogfood-qa-gate.yml |  4 +++-
 scripts/overstory/ci-qa-check.mjs     | 32 ++++++++++++++++++++++-----
 scripts/overstory/qa-merge-gate.sh    |  8 ++++---
 3 files changed, 35 insertions(+), 9 deletions(-)

diff --git a/.github/workflows/dogfood-qa-gate.yml b/.github/workflows/dogfood-qa-gate.yml
index d0d03a9ca..5322cfa59 100644
--- a/.github/workflows/dogfood-qa-gate.yml
+++ b/.github/workflows/dogfood-qa-gate.yml
@@ -114,7 +114,9 @@ jobs:
             try {
               const manifest = JSON.parse(fs.readFileSync('public/dogfood/manifest.json', 'utf8'));
               screenshotCount = (manifest.items || []).length;
-              manifestStatus = screenshotCount >= 23 ? 'pass' : 'low';
+              // One product surface: 4 responsive/theme variants,
+              // 2 interaction states, and 1 settings/theme state.
+              manifestStatus = screenshotCount >= 7 ? 'pass' : 'low';
             } catch {}
 
             try {
diff --git a/scripts/overstory/ci-qa-check.mjs b/scripts/overstory/ci-qa-check.mjs
index 9fe496b01..28f8028bc 100644
--- a/scripts/overstory/ci-qa-check.mjs
+++ b/scripts/overstory/ci-qa-check.mjs
@@ -4,7 +4,8 @@
  *
  * Reads dogfood artifacts from public/dogfood/ and validates:
  * 1. All required manifests exist and are fresh
- * 2. Minimum screenshot coverage (>= 23)
+ * 2. Complete one-surface screenshot coverage (4 route variants + 2
+ *    interactions + 1 settings state)
  * 3. Walkthrough has enough chapters (>= 9)
  * 4. Frames extracted
  * 5. Scribe steps captured
@@ -18,6 +19,11 @@ import { join } from "path";
 
 const REPO_ROOT = process.cwd();
 const DOGFOOD_DIR = join(REPO_ROOT, "public", "dogfood");
+const MIN_ROUTE_SCREENSHOTS = 4;
+const MIN_INTERACTION_SCREENSHOTS = 2;
+const MIN_SETTINGS_SCREENSHOTS = 1;
+const MIN_SCREENSHOTS =
+  MIN_ROUTE_SCREENSHOTS + MIN_INTERACTION_SCREENSHOTS + MIN_SETTINGS_SCREENSHOTS;
 
 const CHECKS = [];
 let passed = true;
@@ -54,15 +60,31 @@ const manifest = readJSON("manifest.json");
 check("manifest exists", !!manifest);
 if (manifest) {
   const items = manifest.items || [];
-  check("screenshot count >= 23", items.length >= 23, `${items.length} screenshots`);
+  check(
+    `screenshot count >= ${MIN_SCREENSHOTS}`,
+    items.length >= MIN_SCREENSHOTS,
+    `${items.length} screenshots`,
+  );
   const age = hoursAgo(manifest.capturedAtIso);
   check("manifest fresh (< 24h)", age < 24, `${Math.floor(age)}h old`);
   const routes = items.filter((i) => i.kind === "route").length;
   const interactions = items.filter((i) => i.kind === "interaction").length;
   const settings = items.filter((i) => i.kind === "settings").length;
-  check("has route screenshots", routes >= 20, `${routes} routes`);
-  check("has interaction screenshots", interactions >= 1, `${interactions} interactions`);
-  check("has settings screenshots", settings >= 1, `${settings} settings`);
+  check(
+    "has responsive/theme route screenshots",
+    routes >= MIN_ROUTE_SCREENSHOTS,
+    `${routes} route variants`,
+  );
+  check(
+    "has interaction screenshots",
+    interactions >= MIN_INTERACTION_SCREENSHOTS,
+    `${interactions} interactions`,
+  );
+  check(
+    "has settings screenshots",
+    settings >= MIN_SETTINGS_SCREENSHOTS,
+    `${settings} settings`,
+  );
 }
 console.log();
 
diff --git a/scripts/overstory/qa-merge-gate.sh b/scripts/overstory/qa-merge-gate.sh
index b1b3e1a3a..d1df8c45e 100644
--- a/scripts/overstory/qa-merge-gate.sh
+++ b/scripts/overstory/qa-merge-gate.sh
@@ -182,10 +182,12 @@ if [ -f "$MANIFEST" ]; then
     console.log((data.items || []).length);
   " 2>/dev/null || echo "0")
 
-  if [ "$SCREENSHOT_COUNT" -lt 30 ]; then
-    FAILURES+=("LOW_COVERAGE: Only $SCREENSHOT_COUNT screenshots (need >= 30)")
+  # One product surface: 4 responsive/theme variants, 2 interaction states,
+  # and 1 settings/theme state. More routes would reward UI sprawl.
+  if [ "$SCREENSHOT_COUNT" -lt 7 ]; then
+    FAILURES+=("LOW_COVERAGE: Only $SCREENSHOT_COUNT screenshots (need >= 7)")
     PASS=false
-    echo "  FAIL: Only $SCREENSHOT_COUNT screenshots (need >= 30)"
+    echo "  FAIL: Only $SCREENSHOT_COUNT screenshots (need >= 7)"
   else
     echo "  OK: $SCREENSHOT_COUNT screenshots"
   fi