Add GridArray constructor from data#133
Open
lcw wants to merge 17 commits into
Open
Conversation
lcw
force-pushed
the
gridarray-from-data
branch
3 times, most recently
from
95b86e4 to
7f3b55e
Compare
lcw
force-pushed
the
gridarray-from-data
branch
from
3af6f69 to
abd811f
Compare
This replaces the persistent MPI communication with MPI.Isend, MPI.Irecv!, and MPI.Wait. This is done because Enzyme currently does not support persistent MPI.
The binding rules changed at the REPL in julia v1.12 breaking this
document test. See the error message below.
```
julia> struct T{A,B}
a::A
b::B
end
julia> Raven.constructorof(T{Int,Int})
ERROR: UndefVarError: `T` not defined in `Main`
Suggestion: define the const at top-level before running function that uses it (stricter Julia v1.12+ rule).
Note: the binding state changed since the error occurred (was: 11, now: 0).
Stacktrace:
[1] #s75#6
@ ~/research/code/julia/Raven/src/flatten.jl:138 [inlined]
[2] var"#s75#6"(T::Any, ::Any, ::Any)
@ Raven ./none:0
[3] (::Core.GeneratedFunctionStub)(::UInt64, ::Method, ::Any, ::Vararg{Any})
@ Base ./expr.jl:1694
[4] top-level scope
@ REPL[3]:1
```
Thus, we just change the example to work.
This change is made to enable Enzyme support.
lcw
force-pushed
the
gridarray-from-data
branch
from
ab61b1e to
8179242
Compare
Here we define enough julia functions for GridVectorView to use them in the OrdinaryDiffEq time-steppers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.