Skip to content

[BUG] Error 227 never issued (Zero roughness not checked for the transect) #50

@cbuahin

Description

@cbuahin

SWMM Version 5.2.4
Version for the SWMM model where the bug was discovered.

Desktop (please complete the following information):

  • OS: [e.g. iOS] Windows 11
  • Version [e.g. 22] 24H2

Describe the bug
The roughness of a transect can be set to zeros. The zero values are ignored and the default values (0.016) are used with no errors/warnings.

To Reproduce
Open the transect editor, set '0' to the roughness and run the simulation.

Expected behavior
Should show Error 227.

Additional context
Zero roughness should be checked in the setManning(double n[]) method in transect.c:

int i;
for (i=1; i<=3; i++)
{
if ( n[i] < 0.0 ) return ERR_NUMBER;
}

if (n[3]==0.0) return ERR_TRANSECT_MANNING;

...

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions