Ensure cache url and etag values are updated if DB doesn't reflect Azure blob storage#105
Merged
Conversation
This makes it easier to check that they exist in the GitHub Actions interface.
This downloads the blob info from Azure and checks that the ETag matches what is in the database, which resolves #104.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
NULL, that means that they are not currently being set for datasets were successfully downloaded before these columns were added but which haven't been updated since).NULL. To properly test would require test code that forces the DB and Azurite into an inconsistent state, which seemed a lot of work for something that is a one-off issue due to the one-time addition of these new columns.