Prevent processing of datasets belonging to unapproved reporting organisations#138
Merged
Merged
Conversation
Contributor
chrisarridge
left a comment
chrisarridge
left a comment
There was a problem hiding this comment.
Couple of small non-breaking comments. Otherwise it looks good.
| def RUN_FOR_N_DATASETS(self) -> int | None: | ||
| return self._RUN_FOR_N_DATASETS | ||
|
|
||
| @property |
Contributor
There was a problem hiding this comment.
Why not make it a bool? Similar remark on line 23?
Contributor
Author
There was a problem hiding this comment.
Yes should be a string - it contains the short name of the reporting org.
| suitecrm_reporting_org_records = [ | ||
| o | ||
| for o in suitecrm_reporting_org_records | ||
| if o.get("attributes", {}).get("iati_short_name", "") == context.RUN_FOR_SINGLE_REPORTING_ORG |
Contributor
There was a problem hiding this comment.
The type hint is for this to be an integer - should it be a string? It's a string in the command line arguments.
| ## [1.4.4] - 2026-04-22 | ||
|
|
||
| ### Fixed | ||
|
|
Contributor
There was a problem hiding this comment.
Add a change for the command line argument addition?
This commit adds a feature to limit processing to a single reporting org, which helps with more targeted debugging when there are issues with real data that need investigating.
Housekeeping commit which fixes most of the outstanding flake8 warnings.
This commit stops unapproved orgs from being downloaded, which in turn stops datasets from those orgs from being included, because any dataset which belongs to an unknown org is rejected. This resolves #136.
simon-20
force-pushed
the
sk-fix-showing-unapproved-orgs--add-test-flag
branch
from
7140447 to
5b0ed1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
--run-for-single-reporting-orgto aid in targeted debuggingflake8warnings and runs some linting on testsThis will resolve #136