PDF function doesnt seem to work on all docs sites

[stevieflow]

Validator is OK, but most of the others do not seem to produce the PDF

[robredpath]

Validator uses the "old" workaround - it's hard coded.

The PDF is getting generated but the link isn't working; it looks like the Jinja variable is missing. I'm unclear as to whether it was something that RTD used to provide but no longer do, or whether it was something that we used to define in conf.py and have inadvertently removed.

I'll take a look and see what I can come up with.

[robredpath]

Fix is merged, awaiting a second pair of eyes before we roll out (see #11 and #12)

[robredpath]

@IATI/devs ^^ (I don't seem to be able to assign to the group!)

[simon-20]

I think only PR reviews can be assigned to the group, not issues themselves, but as you've already merged the PR, the option will have disappeared.

It looks fine to me, but not sure I have the login details to verify what the URL should be.

[robredpath]

Thanks @simon-20 - I can confirm that the URL formation works (it didn't at first, hence why I changed it in #12!). We can always add more conditionality / configurability if this doesn't work for any edge cases, although I think we've done a lot of good work to reduce those of late.

[robredpath]

@IsabelBirds this is ready to go - it'll be a nice quiet-afternoon job for whoever gets to it first