Transform * equal/unequal comparisons to NULL checks#31
Merged
Conversation
nilmerg
added a commit
to Icinga/ipl-orm
that referenced
this pull request
Mar 11, 2021
This will change with Icinga/ipl-sql#31
We previously transformed those to `TRUE` and `FALSE` respectively with the intention to "optimize" our queries. Why not utilize this to finally implement a native way to express an `IS (NOT) NULL` check in our filter syntax? (`name=*` => `name IS NOT NULL`, `name!=*` => `name IS NULL`)
nilmerg
force-pushed
the
transform-wildcard-only-filters-to-null-checks
branch
from
43a5522 to
5bb7e3b
Compare
nilmerg
added a commit
to Icinga/icingaweb2
that referenced
this pull request
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously transformed those to
TRUEandFALSErespectively with the intention to "optimize" our queries. Why not utilize this to finally implement a native way to express anIS (NOT) NULLcheck in our filter syntax?This will lead to this:
name=*=>name IS NOT NULLname!=*=>name IS NULLrefs Icinga/icingaweb2#1740