|
| 1 | +# Implementation Audit Scope Boundary |
| 2 | + |
| 3 | +## Purpose |
| 4 | + |
| 5 | +Record the implementation drifts discovered while checking `docs/30-unit-tdd/business-pipeline-and-authority.md` and related local guides against code, in a task that is explicitly separate from `core-py-post-split-cleanup`. |
| 6 | + |
| 7 | +## Decision |
| 8 | + |
| 9 | +This task is a separate follow-up. |
| 10 | + |
| 11 | +`core-py-post-split-cleanup` remains a SVC v9.3 adoption task about shared baseline consumption, Unit TDD admission, and local `AGENTS.md` strengthening. |
| 12 | + |
| 13 | +Any code changes or implementation verification work should happen here instead of being folded back into that post-split cleanup task. |
| 14 | + |
| 15 | +## Important Caution |
| 16 | + |
| 17 | +Not every issue found during the audit should be assumed to be a code bug. Some apparent mismatches may come from outdated docs, stale local guides, or legacy notes that no longer describe the current implementation correctly. |
| 18 | + |
| 19 | +So every follow-up item below must be re-verified before code changes are made. The decision shape should be: |
| 20 | + |
| 21 | +- code is wrong and should change, or |
| 22 | +- docs / local guides are outdated and should change, or |
| 23 | +- both drifted and need to be realigned together |
| 24 | + |
| 25 | +## Why |
| 26 | + |
| 27 | +The drifts found during implementation review are real signals, but they are not automatically durable-doc placement work. |
| 28 | + |
| 29 | +Under SVC v9.3, code bugs and legacy implementation seams should not be "fixed" by rewriting durable docs to mirror the bug. They should either: |
| 30 | + |
| 31 | +- be corrected in code and tests in a separate execution task, or |
| 32 | +- be reclassified as documentation drift if the code is actually the more current source of truth |
| 33 | + |
| 34 | +## Audit Leads |
| 35 | + |
| 36 | +### 1. Embedding upsert call shape |
| 37 | + |
| 38 | +- `app/business/info_base/block.py` currently calls `EmbeddingManager.upsert_block_embedding(...)` with positional arguments that appear not to match the current signature in `app/business/sink/embedding.py`. |
| 39 | +- This may be a real implementation bug, or a sign that the documented/assumed call contract needs re-verification. |
| 40 | + |
| 41 | +### 2. Extension running-state checks |
| 42 | + |
| 43 | +- `app/business/extension/main.py` checks `RUNNING_EXTENSIONS` using the extension class object, while the registry is keyed by extension ID. |
| 44 | +- This looks like a runtime lifecycle bug, but should still be re-verified against the intended registry contract before changing code. |
| 45 | + |
| 46 | +### 3. Legacy resolver/storage API remnants |
| 47 | + |
| 48 | +- several built-in resolvers still look shaped for older storage APIs or incomplete resolver contracts |
| 49 | +- this includes missing/legacy methods in built-in resolver files and stale references to storage helpers that no longer match the current storage manager shape |
| 50 | +- part of this may be code drift, part of it may be local guide / note drift |
| 51 | + |
| 52 | +### 4. Source scheduling remains undecided |
| 53 | + |
| 54 | +- the current dual-path source scheduling situation was reconfirmed |
| 55 | +- but the scheduling cleanup decision remains a separate design/execution question and should not be silently collapsed into this audit |
| 56 | + |
| 57 | +## Explicit Non-Actions |
| 58 | + |
| 59 | +- do not change `docs/30-unit-tdd/` to normalize temporary broken behavior into durable architecture |
| 60 | +- do not rewrite local `AGENTS.md` to preserve a bug as if it were stable truth |
| 61 | +- do not assume every mismatch is a code bug before re-checking whether the docs are outdated |
| 62 | + |
| 63 | +## Follow-Up Shape |
| 64 | + |
| 65 | +If this work proceeds later, split it into separate execution slices such as: |
| 66 | + |
| 67 | +1. code/task for embedding and extension lifecycle correctness |
| 68 | +2. code/task for resolver/storage legacy cleanup |
| 69 | +3. separate decision task for source scheduling convergence |
0 commit comments