Why doesn't this contract work?

[locallycompact]

Summary

I missed a few months of plutus updates and now I'm trying to bring a contract up to date. As far as I can tell, this is a reduced version of the vesting contract, and I can't see what's wrong.

Validator:

https://gitlab.homotopic.tech/plutus/validators/gift/-/blob/master/src/Plutus/Validators/Gift.hs

Contract:

https://gitlab.homotopic.tech/plutus/contracts/gift/-/blob/e85ae2495f45f96082756bb87ec393dd37b5731e/src/Plutus/Contracts/Gift.hs

Model:

https://gitlab.homotopic.tech/plutus/contracts/gift/-/blob/e85ae2495f45f96082756bb87ec393dd37b5731e/test/Plutus/ContractModel/Gift.hs

Result:

https://gitlab.homotopic.tech/plutus/contracts/gift/-/jobs/198281

Steps to reproduce the behavior

git clone https://gitlab.homotopic.tech/plutus/contracts/gift
nix build

Actual Result

doesn't work

Expected Result

should work

Describe the approach you would take to fix this

i don't know

System info

nixos

[locallycompact]

i feel like this and this issue are quite severe usability regressions compared with plutus-apps only a few months ago.

#942

[berewt]

From the errors, it seems like the last action isn't consider, we had a few problems with time interval and it might be related to the corresponding fix, but I wasn't able to spot where the problem is.