Merge pull request tiagosiebler#520 from tiagosiebler/basepriceproperty

fix(v4.4.5, tiagosiebler#518, tiagosiebler#516): add missing basePrice property for spot orders, fix return type for getP2POrderMessages

Author: tiagosiebler

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "bybit-api",
-  "version": "4.4.4",
+  "version": "4.4.5",
   "description": "Complete & robust Node.js SDK for Bybit's REST APIs and WebSockets, with TypeScript & strong end to end tests.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

package.json

@@ -20,6 +20,7 @@ import {
   AmendOrderParamsV5,
   AmendSpreadOrderParamsV5,
   ApiKeyInfoV5,
+  APIP2PResponse,
   APIResponseV3,
   APIResponseV3WithTime,
   AssetInfoV5,
@@ -3943,7 +3944,7 @@ export class RestClientV5 extends BaseRestClient {
    */
   getP2POrderMessages(
     params: GetP2POrderMessagesParamsV5,
-  ): Promise<APIResponseV3WithTime<P2POrderMessageV5[]>> {
+  ): Promise<APIP2PResponse<P2POrderMessageV5[]>> {
     return this.postPrivate('/v5/p2p/order/message/listpage', params);
   }
 

src/rest-client-v5.ts

@@ -68,6 +68,23 @@ export type APIResponseV3WithTime<TResult, TExtInfo = {}> = APIResponseV3<
   TResult,
   TExtInfo
 > & { time: number };
+
+export interface APIP2PResponse<TResult, TExtInfo = {}> {
+  ret_code: number;
+  ret_msg: string;
+  result: {
+    result: TResult;
+    totalRows: string;
+    totalPages: string;
+    currentPage: string;
+    dayLimit: string;
+    showDayLimit: boolean;
+  };
+  ext_code: string;
+  ext_info: TExtInfo;
+  time_now: string;
+}
+
 /**
  * Request Parameter Types
  */