pysindy.pysindy reference when importing _BaseSINDy does not exist

[llfung]

In src/gen_experiments/odes.py and src/gen_experiments/utils.py , the reference _BaseSINDy is under pysindy.pysindy, which does not exist in >=2.0.0 version of PySINDy?

Should it be pysindy._core instead?

[llfung]

#52

[Jacob-Stevens-Haas]

Yes, it should. Also, BaseSINDy should probably be a part of the public API of pysindy.

Although the larger issue here is that it's common to run into circular dependency issues developing this package in the same project as pysindy (maybe @AHsu98 and @MalachiteWind also ran into this).

The larger problem has several solutions I've considered

• a vendored branch, https://github.com/Jacob-Stevens-Haas/gen-experiments/tree/vendored, that assumes pysindy is installed separately (e.g. both pysindy and gen_experiments as git submodules of a larger project)
• Extracting base types to a stub package that is a dependency of this and pysindy
• redefining _BaseSINDy here as a typing.Protocol to remove explicit and explicit dependence on pysindy.

I've been leaning towards the third, which is quick, and maybe eventually moving to the second.

An example of the larger issue:

I'm hoping to use this package in the asv benchmarks within pysindy for merging the JSINDy stuff. This file largely copies from gen_experiments in order to avoid the circular dependency issue.

Another example of avoiding the circular dependency by copying code.