-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Description
Background
The terraform-apply workflow for infra/aws fails on main because the forge-github-actions-terraform-apply-prod IAM role lacks permissions introduced by recent changes (IAM module for groups/users and ECS autoscaling).
Failing run: https://github.com/JesusFilm/forge/actions/runs/22925832670/job/66535976097
Two categories of errors:
iam:CreateGroup— explicitly denied byDenyIamUserAndGroupMutationin the apply policyapplication-autoscaling:RegisterScalableTarget— not allowed (missing from the service list)
Expected outcome
terraform apply succeeds for infra/aws on both stage and prod branches, creating IAM groups, users, and ECS autoscaling resources.
Acceptance criteria
-
application-autoscaling:*added to theTerraformAwsServiceManagementallow statement - IAM group CRUD allowed, scoped to
arn:aws:iam::*:group/forge-* - IAM user lifecycle allowed, scoped to
arn:aws:iam::*:user/* - Credential-mutation deny guardrail retained (access keys, login profiles, inline user policies)
-
terraform-applyCI passes
Possible solution(s)
- Add
application-autoscaling:*to the existing service-management allow - Split the old
DenyIamUserAndGroupMutationinto scoped allows for groups/users plus a narrower deny for credential mutations
References
- Failed run: https://github.com/JesusFilm/forge/actions/runs/22925832670/job/66535976097
- PR that introduced IAM module + autoscaling: fix(cms): bootstrap internal api token and stage/prod routing #302
Reactions are currently unavailable