Vertaisarviointi #1
Description
Since the documentations in the project are written in English, the code review will also be given in English.
The project makes sense in structure, both algorithms and GUI have their own package. Also different kinds of heaps extends the same abstract class heap, which reduces repeated codes and makes the structure more clearer.
Some improvements
- The test of MinHeapKeepsItOrderAfterDecreaseKey didn't pass in my computer. It seems like the binomial heap takes only there integers at a time.
- For now all heaps accepts only Integer-type. Have you considered about making your heaps accept different types of data using generics?
- It would be better if there could be a test class for BinomialTree. Most of methods in the BinomialTree class are quite simple and I don't think they need to be tested. It would be better if the complicated method link can be tested in its own unit test.
- The method createTestData is used in both MinBinaryHeapTest and MinBinomialHeapTest. Would it be better to create an abstract HeapTest class and put this method to the abstract class so that you don't need to copy the method again when you're writing tests for Fibonacci heap?