From 42311e4ab1e2877ad6ef4a1a84f9d16c18b4af44 Mon Sep 17 00:00:00 2001 From: Michal Babej Date: Thu, 5 Mar 2026 15:02:01 +0200 Subject: [PATCH 1/4] re-enable some FP16 tests on PoCL MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These tests should work on the CI after https://github.com/pocl/pocl/pull/2128 lands in PoCL. Currently it's failing with errors like: Error During Test at /home/runner/work/pocl/pocl/OpenCL.jl/test/intrinsics.jl:116 Unexpected Pass Expression: call_on_device(f, x, y) ≈ f(x, y) Got correct result, please change to @test if no longer broken. --- test/intrinsics.jl | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/intrinsics.jl b/test/intrinsics.jl index 47075df9..57b0d447 100644 --- a/test/intrinsics.jl +++ b/test/intrinsics.jl @@ -96,8 +96,7 @@ end if f == acosh x += 1 end - broken = ispocl && T == Float16 && f in [acosh, asinh, atanh, cbrt, cospi, expm1, log1p, sinpi, tanpi] - @test call_on_device(f, x) ≈ f(x) broken = broken + @test call_on_device(f, x) ≈ f(x) end end @@ -112,8 +111,7 @@ end ] x = rand(T) y = rand(T) - broken = ispocl && T == Float16 && f == atan - @test call_on_device(f, x, y) ≈ f(x, y) broken = broken + @test call_on_device(f, x, y) ≈ f(x, y) end end @@ -138,7 +136,7 @@ end OpenCL.rsqrt, ] x = rand(T) - broken = ispocl && T == Float16 && !(f in [OpenCL.rint, OpenCL.rsqrt]) + broken = ispocl && T == Float16 && (f == OpenCL.logb) @test call_on_device(f, x) isa Real broken = broken # Just check it doesn't error end broken = ispocl && T == Float16 @@ -157,7 +155,7 @@ end ] x = rand(T) y = rand(T) - broken = ispocl && T == Float16 && !(f in [OpenCL.maxmag, OpenCL.minmag]) + broken = ispocl && T == Float16 && (f in [OpenCL.nextafter, OpenCL.powr]) @test call_on_device(f, x, y) isa Real broken = broken # Just check it doesn't error end broken = ispocl && T == Float16 From 76e301a6bb4b61941f884367378bd4ab8cb7c0b0 Mon Sep 17 00:00:00 2001 From: Michal Babej Date: Thu, 5 Mar 2026 17:41:47 +0200 Subject: [PATCH 2/4] temporarily switch PoCL repo to review --- .github/workflows/Test.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/Test.yml b/.github/workflows/Test.yml index e7b28f20..daff12b5 100644 --- a/.github/workflows/Test.yml +++ b/.github/workflows/Test.yml @@ -60,7 +60,8 @@ jobs: if: ${{ matrix.pocl == 'local' }} uses: actions/checkout@v6 with: - repository: pocl/pocl + repository: franz/pocl + ref: fixes path: pocl - name: Install system dependencies From 555fb90990d24c87680d18fc4a33801d0fb2b785 Mon Sep 17 00:00:00 2001 From: Christian Guinard <28689358+christiangnrd@users.noreply.github.com> Date: Thu, 9 Apr 2026 11:46:59 -0300 Subject: [PATCH 3/4] Revert "temporarily switch PoCL repo to review" This reverts commit 1c3685c9b8b97afd56fa20d8227aa9455ba1c032. --- .github/workflows/Test.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/Test.yml b/.github/workflows/Test.yml index daff12b5..e7b28f20 100644 --- a/.github/workflows/Test.yml +++ b/.github/workflows/Test.yml @@ -60,8 +60,7 @@ jobs: if: ${{ matrix.pocl == 'local' }} uses: actions/checkout@v6 with: - repository: franz/pocl - ref: fixes + repository: pocl/pocl path: pocl - name: Install system dependencies From 4e37857f713aab6782eac6e392c3e73ed578fd6a Mon Sep 17 00:00:00 2001 From: Michal Babej Date: Sat, 11 Apr 2026 21:10:11 +0300 Subject: [PATCH 4/4] workflows/Test.yml: add libsleef to build dependencies this is not strictly necessary, but it should help by enabling vectorized builtin variants on ARM64. --- .github/workflows/Test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/Test.yml b/.github/workflows/Test.yml index e7b28f20..ae37a1b2 100644 --- a/.github/workflows/Test.yml +++ b/.github/workflows/Test.yml @@ -67,7 +67,7 @@ jobs: if: ${{ matrix.pocl == 'local' }} run: | sudo apt-get update - sudo apt-get install -y build-essential cmake ninja-build pkg-config + sudo apt-get install -y build-essential cmake ninja-build pkg-config libsleef-dev - name: Install Julia dependencies if: ${{ matrix.pocl == 'local' }}