Things to do before v1.9

[simonschoelly]

I looked a bit at the PRs that we have introduced since v1.8 - it looks mostly good, but there are a few things that we probably should fix before a next release, so that we don't introduce new bugs:

• Remove the GenericGraph(elist::Vector{Graphs.SimpleGraphEdge{T}}) function introduced in Eulerian cycles/trails for undirected graphs #232 => addressed in Remove non-default GenericGraph constructor #308
• Try to fix the bugs that we have on nightly - but I suspect that this might be an issue with JET.jl, so maybe we cannot.

Minor:

• Some normalized_cut() fixes #84 was merged, but that PR uses some magic constant - I am not completely sure that this is the right way - but on the other hand we could argue that this replaces a bug with another one, so maybe we can ignore it.

[gdalle]

Thanks for taking the time!

1. Wanna do it, since you wrote all of the GenericGraph infrastructure?
2. Yeah it has something to do with JET on nightly. My fix would be to keep nightly CI (and not Stop running CI on nightly? #295) but decouple it from the "build passing" badge
3. Do you mean dnz = abs.(diag(D)) .>= 1E-16? Maybe we can do eps(T) instead?

[gdalle]

What do you think about #307?

[gdalle]

Okay, it seems #307 can wait and so can the workaround from #84.

As far as I'm concerned, once #305 and #309 are merged, we're good to tag

[simonschoelly]

@gdalle we can close this, right?