Skip to content

Don't rely on Pkg being present in the juliac env #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asinghvi17 wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Don't rely on Pkg being present in the juliac env #138

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fe3dcaf
Don't rely on Pkg being present in the juliac env
asinghvi17 May 12, 2026
52b7c7f
Fix accidentally deleted newline
asinghvi17 May 12, 2026
3510d24
Evade string issues by passing the project path as an argument to the…
asinghvi17 May 12, 2026
d1236e4
Revert "Don't rely on Pkg being present in the juliac env"
asinghvi17 May 12, 2026
f1dbb65
Set JULIA_LOAD_PATH explicitly for the precompile subprocess
asinghvi17 May 12, 2026
2edcccf
Condense comment
asinghvi17 May 12, 2026
fb5bb32
Don't inherit JULIA_LOAD_PATH from the parent for the precompile subp…
asinghvi17 May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/compiling.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,10 @@ function compile_products(recipe::ImageRecipe)
end
project_arg = isdir(project_arg) ? tmp_project : joinpath(tmp_project, basename(project_arg))

env_overrides = Dict{String,Any}()
# Drop any inherited JULIA_LOAD_PATH (e.g. set by the Pkg-app shim to
# JuliaC's own env) so the subprocess falls back to the default
# ["@", "@v#.#", "@stdlib"] and `using Pkg` resolves via @stdlib.
env_overrides = Dict{String,Any}("JULIA_LOAD_PATH" => nothing)
tmp_prefs_env = nothing
if is_trim_enabled(recipe)
load_path_sep = Sys.iswindows() ? ";" : ":"
Expand All @@ -119,8 +122,8 @@ function compile_products(recipe::ImageRecipe)
println(io, "[HostCPUFeatures]")
println(io, "freeze_cpu_target = true")
end
# Append the temp env to JULIA_LOAD_PATH

# Leading separator → an empty entry that expands to the default load path,
# then append the temp prefs env.
env_overrides["JULIA_LOAD_PATH"] = load_path_sep * tmp_prefs_env
end

Expand Down
Loading