From e349e20311f03802f7f2171700c2fa4e9820a55d Mon Sep 17 00:00:00 2001 From: Chengyu HAN Date: Sat, 14 Dec 2024 00:20:22 +0800 Subject: [PATCH 01/11] ci: run on macos-x64 --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index f2047c86..16e5abfa 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -32,7 +32,7 @@ jobs: - '1' os: - ubuntu-latest - - macOS-latest + - macos-13 # Intel - windows-latest arch: - x64 From 19b0faa17f4ad3c960501d5be135a54a58e71d7e Mon Sep 17 00:00:00 2001 From: Chengyu HAN Date: Sat, 14 Dec 2024 10:04:46 +0800 Subject: [PATCH 02/11] ci: test with macos-aarch64 --- .github/workflows/CI.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 16e5abfa..7e7f667f 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -36,6 +36,17 @@ jobs: - windows-latest arch: - x64 + include: + # macos-latest -> Apple Silicon + - os: macos-latest + julia-arch: 'aarch64' + julia-version: '1.0' + - os: macos-latest + julia-arch: 'aarch64' + julia-version: '1' + - os: macos-latest + julia-arch: 'aarch64' + julia-version: 'nightly' steps: - uses: actions/checkout@v6 - uses: julia-actions/setup-julia@v2 From 485ecf82a0a617bf5e6147b46606ee4b4c5e07ec Mon Sep 17 00:00:00 2001 From: Chengyu HAN Date: Sat, 14 Dec 2024 10:10:58 +0800 Subject: [PATCH 03/11] ci: fix typo in build matrix --- .github/workflows/CI.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 7e7f667f..d6d64b68 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -39,14 +39,14 @@ jobs: include: # macos-latest -> Apple Silicon - os: macos-latest - julia-arch: 'aarch64' - julia-version: '1.0' + arch: 'aarch64' + version: '1.0' - os: macos-latest - julia-arch: 'aarch64' - julia-version: '1' + arch: 'aarch64' + version: '1' - os: macos-latest - julia-arch: 'aarch64' - julia-version: 'nightly' + arch: 'aarch64' + version: 'nightly' steps: - uses: actions/checkout@v6 - uses: julia-actions/setup-julia@v2 From ca25f378d895d3cd450fc95a3a6066b7e99eaac7 Mon Sep 17 00:00:00 2001 From: Chengyu HAN Date: Sat, 14 Dec 2024 10:20:04 +0800 Subject: [PATCH 04/11] ci: test macos-latest with lts > Julia 1.6 and 1.7 do not have native binaries available for Apple Silicon macOS. --- .github/workflows/CI.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index d6d64b68..4a5ac6bd 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -37,10 +37,10 @@ jobs: arch: - x64 include: - # macos-latest -> Apple Silicon + # macos-latest -> Apple Silicon (Need julia >= v1.8) - os: macos-latest arch: 'aarch64' - version: '1.0' + version: 'lts' - os: macos-latest arch: 'aarch64' version: '1' From 09b22c9a3d4b80026471d3d6ba333cd8ca14ac3e Mon Sep 17 00:00:00 2001 From: Chengyu HAN Date: Sat, 14 Dec 2024 10:58:01 +0800 Subject: [PATCH 05/11] ci: fix deprecated arg `file` --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 4a5ac6bd..4da742f9 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -61,4 +61,4 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} # required fail_ci_if_error: true - file: lcov.info + files: lcov.info From 36db5392c348e8493049339353940c8f2c998f35 Mon Sep 17 00:00:00 2001 From: Chengyu HAN Date: Sat, 14 Dec 2024 10:59:30 +0800 Subject: [PATCH 06/11] README: update codecov badge --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 11ad15a5..bdd6a015 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ A general framework for fast Fourier transforms (FFTs) in Julia. [![GHA](https://github.com/JuliaMath/AbstractFFTs.jl/workflows/CI/badge.svg)](https://github.com/JuliaMath/AbstractFFTs.jl/actions?query=workflow%3ACI+branch%3Amaster) -[![Codecov](http://codecov.io/github/JuliaMath/AbstractFFTs.jl/coverage.svg?branch=master)](http://codecov.io/github/JuliaMath/AbstractFFTs.jl?branch=master) +[![Codecov](https://codecov.io/github/JuliaMath/AbstractFFTs.jl/graph/badge.svg?token=ZJrE86Hpz7)](https://codecov.io/github/JuliaMath/AbstractFFTs.jl) [![Aqua QA](https://raw.githubusercontent.com/JuliaTesting/Aqua.jl/master/badge.svg)](https://github.com/JuliaTesting/Aqua.jl) Documentation: From 262b368795fe72dc7fd0ddc8d15590550bded920 Mon Sep 17 00:00:00 2001 From: Chengyu Han Date: Wed, 18 Dec 2024 08:57:26 +0800 Subject: [PATCH 07/11] Apply suggestions from code review Co-authored-by: David Widmann --- .github/workflows/CI.yml | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 4da742f9..90b441a2 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -32,21 +32,14 @@ jobs: - '1' os: - ubuntu-latest - - macos-13 # Intel + - macos-latest # Apple silicon - windows-latest - arch: - - x64 - include: - # macos-latest -> Apple Silicon (Need julia >= v1.8) - - os: macos-latest - arch: 'aarch64' - version: 'lts' + exclude: - os: macos-latest - arch: 'aarch64' - version: '1' - - os: macos-latest - arch: 'aarch64' - version: 'nightly' + version: '1.0' + include: + - os: macos-13 # Intel + version: '1.0' steps: - uses: actions/checkout@v6 - uses: julia-actions/setup-julia@v2 From 8cac686c366bc97d6e8e1589940d26f3ceb4bc5e Mon Sep 17 00:00:00 2001 From: Chengyu HAN Date: Wed, 18 Dec 2024 08:58:13 +0800 Subject: [PATCH 08/11] ci: Remove matrix.arch --- .github/workflows/CI.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 90b441a2..51ade734 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -45,7 +45,6 @@ jobs: - uses: julia-actions/setup-julia@v2 with: version: ${{ matrix.version }} - arch: ${{ matrix.arch }} - uses: julia-actions/cache@v3 - uses: julia-actions/julia-buildpkg@v1 - uses: julia-actions/julia-runtest@v1 From a7d4f706b328824cfdbac8e46163b4b37cd53b1c Mon Sep 17 00:00:00 2001 From: Chengyu HAN Date: Wed, 18 Dec 2024 15:43:45 +0800 Subject: [PATCH 09/11] ci: Remove matrix.arch from the name of the job --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 51ade734..339e80f8 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -21,7 +21,7 @@ on: jobs: test: - name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ matrix.arch }} - ${{ github.event_name }} + name: Julia ${{ matrix.version }} - ${{ matrix.os }} - ${{ github.event_name }} runs-on: ${{ matrix.os }} strategy: fail-fast: false From b9a44e9717c87ad009c3fedf53fe7706eab174b3 Mon Sep 17 00:00:00 2001 From: Chengyu HAN Date: Fri, 9 May 2025 22:25:43 +0800 Subject: [PATCH 10/11] ci: update GHA badge --- README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/README.md b/README.md index bdd6a015..7575a53b 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ A general framework for fast Fourier transforms (FFTs) in Julia. -[![GHA](https://github.com/JuliaMath/AbstractFFTs.jl/workflows/CI/badge.svg)](https://github.com/JuliaMath/AbstractFFTs.jl/actions?query=workflow%3ACI+branch%3Amaster) +[![CI](https://github.com/JuliaMath/AbstractFFTs.jl/actions/workflows/CI.yml/badge.svg)](https://github.com/JuliaMath/AbstractFFTs.jl/actions/workflows/CI.yml?query=branch%3Amaster) [![Codecov](https://codecov.io/github/JuliaMath/AbstractFFTs.jl/graph/badge.svg?token=ZJrE86Hpz7)](https://codecov.io/github/JuliaMath/AbstractFFTs.jl) [![Aqua QA](https://raw.githubusercontent.com/JuliaTesting/Aqua.jl/master/badge.svg)](https://github.com/JuliaTesting/Aqua.jl) @@ -18,4 +18,3 @@ This allows multiple FFT packages to co-exist with the same underlying `fft(x)` ## Developer information To define a new FFT implementation in your own module, see [defining a new implementation](https://juliamath.github.io/AbstractFFTs.jl/stable/implementations/#Defining-a-new-implementation). - From 19fc41ecc1ca1d3401020ebbabc33a365861e130 Mon Sep 17 00:00:00 2001 From: "Viral B. Shah" Date: Mon, 23 Feb 2026 00:23:05 -0500 Subject: [PATCH 11/11] Update CI workflow to change Julia version matrix --- .github/workflows/CI.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 339e80f8..53cc13cb 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -32,14 +32,14 @@ jobs: - '1' os: - ubuntu-latest - - macos-latest # Apple silicon + - macos-15-intel - windows-latest exclude: - os: macos-latest version: '1.0' include: - - os: macos-13 # Intel - version: '1.0' + - os: macos-latest # Apple Silicon + version: '1' steps: - uses: actions/checkout@v6 - uses: julia-actions/setup-julia@v2