Skip to content

Products.jl: Improve error message #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giordano merged 2 commits into from
Feb 15, 2026
Merged

Products.jl: Improve error message #462

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c481dea
Products.jl: Improve error message
eschnett Feb 5, 2026
faf40fb
Products: Improve error messages
eschnett Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Products.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ struct LibraryProduct <: Product
dont_dlopen::Bool=false,
dlopen_flags::Vector{Symbol}=Symbol[])
if isdefined(Base, varname)
error("`$(varname)` is already defined in Base")
error("Cannot define a LibraryProduct with name `$(varname)`. This symbol is already defined in Base.")
end
# catch invalid flags as early as possible
for flag in dlopen_flags
Expand Down Expand Up @@ -353,7 +353,7 @@ struct ExecutableProduct <: Product

function ExecutableProduct(binnames::Vector{String}, varname::Symbol, dir_path::Union{AbstractString, Nothing}=nothing)
if isdefined(Base, varname)
error("`$(varname)` is already defined in Base")
error("Cannot define an ExecutableProduct with name `$(varname)`. This symbol is already defined in Base.")
end
# If some other kind of AbstractString is passed in, convert it
if dir_path !== nothing
Expand Down Expand Up @@ -451,7 +451,7 @@ struct FileProduct <: Product
variable_name::Symbol
function FileProduct(paths::Vector{String}, varname::Symbol)
if isdefined(Base, varname)
error("`$(varname)` is already defined in Base")
error("Cannot define a FileProduct with name `$(varname)`. This symbol is already defined in Base.")
end
return new(paths, varname)
end
Expand Down