LibGit2: New version 1.9.2

[eschnett]

No description provided.

[giordano]

Why is LLVMCompilerRT_jll being installed on a non-msan build? That's wrong.

[giordano]

This is not the right way to do, PackageSpec in v1.12 prefers taking strings as versions rather than a version number, there are loads of PRs doing that, see #12627 and just search for the error message. But #12728 (comment) should be resolved first, that's unrelated to the the PackageSpec stuff

[eschnett]

There is

    BuildDependency(PackageSpec(name="LLVMCompilerRT_jll", uuid="4e17d02c-6bf5-513e-be62-445f41c75a11", version=llvm_version);
                    platforms=filter(p -> sanitize(p)=="memory", platforms)),

I do not understand why this installs LLVMCompilerRT_jll on a non-msan build.

[eschnett]

Maybe it's just the check that is happening for all targets?

[giordano]

Maybe it's just the check that is happening for all targets?

No, it's not otherwise all platforms would have failed.

[eschnett]

I do not understand why the non-msan x86_64 build installs LLVMCompilerRT_jll, and I do not know how to fix it. My best guess is that the BuildDependency platform filter ignores the sanity attribute. That is, the platform list here is [x86_64-linux-gnu-sanitize+memory], and this platform somehow matches when x86_64-linux-gnu is built. I do not know where this check happens, though.

[giordano]

I do not know where this check happens, though.

https://docs.binarybuilder.org/stable/reference/#BinaryBuilderBase.filter_platforms-Tuple{AbstractVector{%3C:AbstractDependency},%20AbstractPlatform} -> https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/081355e1f093ab4548ec92d41fb7d85e29b061c3/src/Dependencies.jl#L272 -> https://github.com/JuliaLang/julia/blob/8fd607a7df9e65ed060c88f32d801c95aa8a573f/base/binaryplatforms.jl#L1052-L1104

[eschnett]

Yes, that is the reason:

julia> p1 = Platform("x86_64", "linux"; libc="gnu")
julia> p2 = Platform("x86_64", "linux"; libc="gnu", sanitize="memory")
julia> platforms_match(p1, p2)
true

julia> platforms_match(p2, p1)
true

That's also documented for platforms_match:

"Return true if a and b are matching platforms, where matching is determined by
comparing all keys contained within the platform objects, and if both objects contain
entries for that key, they must match."

(emphasis mine).

[eschnett]

Is there anything else to do? The pattern platforms=filter(p -> sanitize(p)=="memory", platforms) is commonly used for memory sanitizer builds. If there is a bug then it's not here in LibGit2.

[giordano]

Is there anything else to do?

Use platforms_match_with_sanitize instead of platforms_match at https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/081355e1f093ab4548ec92d41fb7d85e29b061c3/src/Dependencies.jl#L272 (with tests).

If there is a bug then it's not here in LibGit2.

Of course, but it's an issue regardless.

[eschnett]

JuliaPackaging/BinaryBuilderBase.jl#458

[eschnett]

Ping?

[giordano]

You need to rebuild this.

[eschnett]

I see this message in the build log:

ERROR: could not load library "/cache/build/yggy-amdci7-5/julialang/yggdrasil/L/LibGit2/build/x86_64-linux-gnu-sanitize+memory/z8XyFtMJ/x86_64-linux-gnu-libgfortran3-cxx11-sanitize+memory/destdir/lib/libgit2.so.1.9.2"
/cache/build/yggy-amdci7-5/julialang/yggdrasil/L/LibGit2/build/x86_64-linux-gnu-sanitize+memory/z8XyFtMJ/x86_64-linux-gnu-libgfortran3-cxx11-sanitize+memory/destdir/lib/libssh2.so.1: undefined symbol: __msan_memset
┌ Warning: lib/libgit2.so.1.9.2 cannot be dlopen()'ed
└ @ BinaryBuilder.Auditor /cache/julia-buildkite-plugin/depots/e2fd9734-29d8-45cd-b0eb-59f7104f3131/packages/BinaryBuilder/EZ7Lf/src/Auditor.jl:222

Is this expected or a problem?

[giordano]

Non-msan julia build can't dlopen msan libraries.