[biome] Update to version to 2.4.8#13366
Conversation
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
| # "39c685ea028d5dd8db101b93c96a0956fb6f7846da93caa49231a62c612daa77"), | ||
| ArchiveSource("https://github.com/biomejs/biome/archive/refs/tags/@biomejs/biome@2.0.6.tar.gz", | ||
| "52d5e449346bfb15855a3bac85ba5d43b81d0fb1a99be9d4b7dca8c51521404c"), | ||
| ArchiveSource("https://github.com/biomejs/biome/archive/refs/tags/@biomejs/biome@$(version).tar.gz", |
There was a problem hiding this comment.
Wait a second, now, that I look more closely to this URL: this is an autogenerated tarball? We don't allow them, how's this not failing: https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/6a5740caa748622f8cae11b437d93946b2dda145/src/Sources.jl#L29?
There was a problem hiding this comment.
Should it be a GitSource instead?
There was a problem hiding this comment.
Yes, but it's not clear to me why this isn't erroring
There was a problem hiding this comment.
Ah, the release is called @biomejs/biome@2.4.8, that has an extra / and it screws up the pattern matching
There was a problem hiding this comment.
how's this not failing
As far as I can tell, in this case the tag has a / in it (@biomejs/biome@2.4.8) so the last [^/]+ doesn't match the tag. Should be replaced with just .+?
There was a problem hiding this comment.
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
2 participants
This is the currently latest version. This was originally held back because we didn't have a new enough Rust toolchain here (x-ref: #12543 (comment)).