[Xorg_xkeyboard_config] Build per-platform to fix Windows install#13680
Merged
maleadt merged 1 commit intoMay 18, 2026
Merged
Conversation
Starting with 2.47 the upstream `ninja install` creates symlinks (`share/X11/xkb`, `share/pkgconfig/xkeyboard-config.pc`, and `share/man/man7/xkeyboard-config.7`) where 2.44 had none. With the recipe set to `[AnyPlatform()]` these symlinks end up in the universal `Xorg_xkeyboard_config.v2.47.0.any.tar.gz` and prevent extraction on Windows for users without `SeCreateSymbolicLinkPrivilege` (developer mode off, non-elevated shell — the default for end users). Verified: artifact `051bcd87a956c48ab829b7da04a56222c10f0a47` (`v2.47.0+0`) contains the three symlinks above; artifact `23d821271a00e164eb2b5c273985da44f9a831a1` (`v2.44.0+0`) contains zero. Switching to `supported_platforms()` matches the precedent in `iso_codes` (JuliaPackaging#7926, refined in JuliaPackaging#10894) and `adwaita_icon_theme` (JuliaPackaging#7930): BinaryBuilder's per-platform packaging materialises the symlinks as copies in the Windows tarball, while the contents remain identical across platforms.
maleadt
approved these changes
May 8, 2026
Member
maleadt
left a comment
maleadt
left a comment
There was a problem hiding this comment.
LGTM. cc @eschnett who did the last bump here.
@giordano Should we run the symlink removal for AnyPlatform builds?
Member
|
Looks like JuliaPackaging/BinaryBuilder.jl#1430 is stuck on CI issues, so let's go ahead with this version already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with 2.47, the upstream
xkeyboard-configninja installstep creates symlinks at:share/X11/xkbshare/pkgconfig/xkeyboard-config.pcshare/man/man7/xkeyboard-config.7where 2.44's install did not. With the recipe set to
[AnyPlatform()], those symlinks end up in the universalXorg_xkeyboard_config.v2.47.0.any.tar.gzand prevent extraction on Windows for users who don't holdSeCreateSymbolicLinkPrivilege(developer mode off, non-elevated shell — the default for end users).Verified directly:
051bcd87a956c48ab829b7da04a56222c10f0a47v2.47.0+023d821271a00e164eb2b5c273985da44f9a831a1v2.44.0+0Switching to
supported_platforms()matches the precedent iniso_codes(#7926, refined in #10894) andadwaita_icon_theme(#7930): BinaryBuilder's per-platform packaging materialises the symlinks as copies on Windows, while the contents remain identical across platforms. The recipe comment is reused verbatim from the iso_codes 4.17 PR for consistency.The artifact is data-only (no native code), so per-platform builds are straightforward.
Disclaimer: investigated and generated by Claude. Surfaced in a private repository.