Skip to content

Commit c8ff89f

Browse files
committed
tests/LU: Use higher tolerance for FP32
1 parent 514bf08 commit c8ff89f

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

test/array/linalg/lu.jl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
U_DA = Array(lu_DA.U)
1414
P_DA = Array(lu_DA.P)
1515
if !(T in (Float32, ComplexF32) && pivot == NoPivot()) # FIXME: NoPivot is unstable for FP32
16-
tol_fact = T in (Float32, ComplexF32) ? 1e-4 : 1e-12
16+
tol_fact = T in (Float32, ComplexF32) ? 1e-2 : 1e-12
1717
@test P_DA * B L_DA * U_DA rtol=tol_fact
1818
end
1919
@test istriu(U_DA)
@@ -26,7 +26,7 @@
2626
b = rand(T, 128)
2727
x_direct = B \ b
2828
x_lu = lu_DA \ b
29-
tol = T in (Float32, ComplexF32) ? 1e-3 : 1e-6
29+
tol = T in (Float32, ComplexF32) ? 1e-2 : 1e-6
3030
@test Array(x_lu) x_direct rtol=tol
3131

3232
# Check that lu did not modify A or DA
@@ -43,7 +43,7 @@
4343
U_DA = Array(lu_DA.U)
4444
P_DA = Array(lu_DA.P)
4545
if !(T in (Float32, ComplexF32) && pivot == NoPivot()) # FIXME: NoPivot is unstable for FP32
46-
tol_fact = T in (Float32, ComplexF32) ? 1e-4 : 1e-12
46+
tol_fact = T in (Float32, ComplexF32) ? 1e-2 : 1e-12
4747
@test P_DA * B L_DA * U_DA rtol=tol_fact
4848
end
4949
@test istriu(U_DA)
@@ -56,7 +56,7 @@
5656
b = rand(T, 128)
5757
x_direct = B \ b
5858
x_lu = lu_DA \ b
59-
tol = T in (Float32, ComplexF32) ? 1e-3 : 1e-6
59+
tol = T in (Float32, ComplexF32) ? 1e-2 : 1e-6
6060
@test Array(x_lu) x_direct rtol=tol
6161

6262
# Check that changes propagated to A
@@ -84,4 +84,4 @@
8484

8585
# Singular Values
8686
@test_throws LinearAlgebra.SingularException lu(ones(Blocks(64,64), T, 128, 128)) # FIXME: NoPivot needs to handle info
87-
end
87+
end

0 commit comments

Comments
 (0)