Problem
discover.sh silently continues when gh search issues fails (line ~115). It returns (search failed or returned no results) without distinguishing:
- Zero results (valid, continue)
- API failure (should warn with details)
- Authentication failure (should die)
Why
Found during P1 skills audit (session 2026-03-27). evaluate.sh handles this correctly (|| die "Failed to fetch"), but discover.sh is lenient. Inconsistent error handling across scripts.
Proposed Fix
Check gh exit code and stderr separately. Die on auth/API failures, continue gracefully on empty results.
References
- Audit finding from skills session 2026-03-27
- Compare with
evaluate.sh lines 51, 99 for correct pattern
Problem
discover.shsilently continues whengh search issuesfails (line ~115). It returns(search failed or returned no results)without distinguishing:Why
Found during P1 skills audit (session 2026-03-27).
evaluate.shhandles this correctly (|| die "Failed to fetch"), butdiscover.shis lenient. Inconsistent error handling across scripts.Proposed Fix
Check
ghexit code and stderr separately. Die on auth/API failures, continue gracefully on empty results.References
evaluate.shlines 51, 99 for correct pattern