From f02a2d0b05c98abdc8a25106a8abc2f00b85f2a6 Mon Sep 17 00:00:00 2001 From: Kaylee <65376239+KayleeWilliams@users.noreply.github.com> Date: Tue, 11 Aug 2026 13:27:09 +0100 Subject: [PATCH 1/2] Run lint and typecheck in CI CI ran build, test and perf but never ran bun run check, so lint and type regressions could land unnoticed. The step runs after the build because benchmarks/joyful.bench.ts imports from dist, which makes typecheck fail on a clean checkout otherwise. --- .github/workflows/ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2ae56dd..eea9134 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,9 +29,14 @@ jobs: - name: Install dependencies run: bun install + # Must run after the build: benchmarks/joyful.bench.ts imports from + # dist, so typecheck fails on a clean checkout without it. - name: Build run: bun run build + - name: Lint and typecheck + run: bun run check + - name: Run tests run: bun test From 39351f6033096ed2d9eebf8918ee8255c8215c53 Mon Sep 17 00:00:00 2001 From: Kaylee <65376239+KayleeWilliams@users.noreply.github.com> Date: Tue, 11 Aug 2026 13:41:56 +0100 Subject: [PATCH 2/2] Run CI on pull requests targeting any branch The pull_request branches filter matches a pull request's base branch, so restricting it to main meant stacked pull requests never ran CI at all: each one targets the branch below it rather than main. Dropping the filter means every pull request is checked, not just the bottom of a stack. --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index eea9134..269302b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,8 +1,10 @@ name: CI on: + # No branch filter: `branches` matches a pull request's base, so restricting + # it to main skipped CI entirely on stacked pull requests, which target the + # branch below them rather than main. pull_request: - branches: [main] permissions: contents: read