Skip to content

Commit 10b895d

Browse files
authored
Update ci.yml
1 parent 5b2942b commit 10b895d

1 file changed

Lines changed: 10 additions & 18 deletions

File tree

.github/workflows/ci.yml

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,8 @@ jobs:
4242
- name: Build API Gateway image
4343
run: docker build -t api-gateway ./api-gateway
4444

45-
4645
docker-scout:
4746
needs: build-and-test
48-
if: ${{ secrets.DOCKER_NAME != '' && secrets.DOCKER_TOKEN != '' }}
4947
runs-on: ubuntu-latest
5048
permissions:
5149
contents: read
@@ -73,34 +71,28 @@ jobs:
7371
- name: Set up Docker Buildx
7472
uses: docker/setup-buildx-action@v3
7573

76-
# 🔐 Đăng nhập Docker Hub (rất quan trọng để tránh lỗi "user githubactions not entitled")
7774
- name: Log in to Docker Hub
7875
uses: docker/login-action@v3
7976
with:
8077
username: ${{ secrets.DOCKER_NAME }}
8178
password: ${{ secrets.DOCKER_TOKEN }}
8279

83-
- name: Build ${{ matrix.service }} service image
84-
run: |
85-
docker build -t docker.io/${{ secrets.DOCKER_NAME }}/${{ matrix.image }}:scout ${{ matrix.context }}
80+
- name: Build ${{ matrix.service }} image
81+
run: docker build -t ${{ matrix.image }}:scout ${{ matrix.context }}
8682

87-
# 🧪 Phân tích bằng Docker Scout
8883
- name: Analyze ${{ matrix.service }} image with Docker Scout
8984
uses: docker/scout-action@v1
9085
with:
9186
command: cves
92-
image: docker.io/${{ secrets.DOCKER_NAME }}/${{ matrix.image }}:scout
93-
accept-license: true
94-
exit-code: false
87+
image: ${{ matrix.image }}:scout
9588
sarif-file: ${{ matrix.image }}-docker-scout.sarif
96-
write-comment: false
97-
github-token: ${{ secrets.GITHUB_TOKEN }}
89+
exit-code: false
90+
accept-license: true
9891

99-
# 📤 Upload kết quả dạng SARIF để GitHub hiển thị trong Security tab
10092
- name: Upload Docker Scout results
10193
uses: github/codeql-action/upload-sarif@v3
10294
with:
103-
sarif_file: ${{ matrix.image }}-docker-scout.sarif }
95+
sarif_file: ${{ matrix.image }}-docker-scout.sarif
10496

10597

10698
push-docker-images:
@@ -123,7 +115,7 @@ jobs:
123115

124116
- name: Build and push service images
125117
env:
126-
REGISTRY: docker.io/${{ secrets.DOCKER_NAME }}
118+
REGISTRY: ${{ secrets.DOCKER_NAME }}
127119
GIT_SHA: ${{ github.sha }}
128120
run: |
129121
if [ -z "$REGISTRY" ]; then
@@ -136,17 +128,17 @@ jobs:
136128
IMAGE_SHA="$REGISTRY/$service:${GIT_SHA::7}"
137129
IMAGE_LATEST="$REGISTRY/$service:latest"
138130
139-
echo "🔧 Building and pushing $service..."
131+
echo "Building and pushing $service..."
140132
docker build -t "$IMAGE_SHA" -t "$IMAGE_LATEST" "./$service"
141133
docker push "$IMAGE_SHA"
142134
docker push "$IMAGE_LATEST"
143135
done
144136
145-
- name: Debug secrets
137+
- name: Confirm secrets status
146138
run: |
147139
if [ -z "${{ secrets.DOCKER_NAME }}" ] || [ -z "${{ secrets.DOCKER_TOKEN }}" ]; then
148140
echo "Missing Docker secrets"
149141
exit 1
150142
else
151-
echo "Docker secrets found"
143+
echo "Docker secrets found and used successfully"
152144
fi

0 commit comments

Comments
 (0)