From f7c6a283ff8c6aacffee75877bbb2da69c66d22b Mon Sep 17 00:00:00 2001 From: Paul Elliott Date: Mon, 19 Oct 2026 13:37:01 -0400 Subject: [PATCH] refactor(volume-property)!: remove deprecated range setter BREAKING CHANGE: setAverageIPScalarRange(min, max) is removed. Use setIpScalarRange(min, max) on vtkVolumeProperty instead. --- BREAKING_CHANGES.md | 1 + Sources/Rendering/Core/VolumeMapper/index.js | 1 - Sources/Rendering/Core/VolumeProperty/index.d.ts | 7 ------- Sources/Rendering/Core/VolumeProperty/index.js | 5 ----- 4 files changed, 1 insertion(+), 13 deletions(-) diff --git a/BREAKING_CHANGES.md b/BREAKING_CHANGES.md index 8c42cbf61e5..6aaac730201 100644 --- a/BREAKING_CHANGES.md +++ b/BREAKING_CHANGES.md @@ -4,6 +4,7 @@ - **TypeScript libraries**: typed-array factories now declare BigInt support. Add `ES2020.BigInt` if your `lib` list does not include `ES2020` or later. Your `target` can stay unchanged. - **Accessor types**: `setXFrom` methods and setters that return no value now declare `void`. Getter types include `null` or `undefined` where applicable. - **`Point` type removed.** Import `Vector3` from `@kitware/vtk.js/types` instead. +- **vtkVolumeProperty**: replace `setAverageIPScalarRange(min, max)` with `setIpScalarRange(min, max)`. - **vtkOpenGLFramebuffer**: replace `getColorTexture()` with `getColorBuffers()[0]`. ## From 36.x to 37 diff --git a/Sources/Rendering/Core/VolumeMapper/index.js b/Sources/Rendering/Core/VolumeMapper/index.js index ec6192291b6..9e5eade65d2 100644 --- a/Sources/Rendering/Core/VolumeMapper/index.js +++ b/Sources/Rendering/Core/VolumeMapper/index.js @@ -47,7 +47,6 @@ const methodNamesMovedToVolumeProperties = [ 'getPreferSizeOverAccuracy', 'getVolumetricScatteringBlending', 'setAnisotropy', - 'setAverageIPScalarRange', 'setComputeNormalFromOpacity', 'setFilterMode', 'setFilterModeToNormalized', diff --git a/Sources/Rendering/Core/VolumeProperty/index.d.ts b/Sources/Rendering/Core/VolumeProperty/index.d.ts index 335a79beff5..304432fbdfc 100755 --- a/Sources/Rendering/Core/VolumeProperty/index.d.ts +++ b/Sources/Rendering/Core/VolumeProperty/index.d.ts @@ -479,13 +479,6 @@ export interface vtkVolumeProperty extends vtkObject { */ getLAOKernelRadius(): number; - /** - * @deprecated use setIpScalarRange - * @param x - * @param y - */ - setAverageIPScalarRange(x: number, y: number): void; - /** * * @param x diff --git a/Sources/Rendering/Core/VolumeProperty/index.js b/Sources/Rendering/Core/VolumeProperty/index.js index c950f0cff3a..c312a873a2a 100644 --- a/Sources/Rendering/Core/VolumeProperty/index.js +++ b/Sources/Rendering/Core/VolumeProperty/index.js @@ -248,11 +248,6 @@ function vtkVolumeProperty(publicAPI, model) { publicAPI[`get${cap}`] = (index) => model.componentData[index][`${val}`]; }); - publicAPI.setAverageIPScalarRange = (min, max) => { - console.warn('setAverageIPScalarRange is deprecated use setIpScalarRange'); - publicAPI.setIpScalarRange(min, max); - }; - publicAPI.getFilterModeAsString = () => macro.enumToString(FilterMode, model.filterMode);